Commit ffc0274a authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

test/iscsi: initialize igs before adding to ig map 



Similar to 759e5934 (test/iscsi: initialize pgs before adding to pg
map), make sure the spdk_scsi_ig structures are zero-initialized before
passing them to spdk_iscsi_pg_map_add_ig_map().

Fixes Valgrind "Conditional jump or move depends on uninitialised
value(s)" errors in two tests.

Change-Id: I38c095aa7c6a89cb9332618b63fe12a02bcf3c2a
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/391000


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
parent f8444357

test/unit/lib/iscsi/tgt_node.c/tgt_node_ut.c

+5 −0
Original line number Diff line number Diff line
@@ -324,6 +324,9 @@ node_access_multi_initiator_groups_cases(void) 
	char *iqn, *addr;

	bool result;



	memset(&ig1, 0, sizeof(ig1));

	memset(&ig2, 0, sizeof(ig2));



	/* target initialization */

	memset(&tgtnode, 0, sizeof(struct spdk_iscsi_tgt_node));

	tgtnode.name = IQN1;
@@ -575,6 +578,8 @@ allow_iscsi_name_multi_maps_case(void) 
	char *iqn;

	bool result;



	memset(&ig, 0, sizeof(ig));



	/* target initialization */

	memset(&tgtnode, 0, sizeof(struct spdk_iscsi_tgt_node));

	TAILQ_INIT(&tgtnode.pg_map_head);