Commit 759e5934 authored by Jim Harris's avatar Jim Harris
Browse files

test/iscsi: initialize pgs before adding to pg map 



This fixes some issues found with Valgrind (incidentally *not*
found with ASAN).

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I49bbd4b338299568eaa4a118aa82fc411037cea7

Reviewed-on: https://review.gerrithub.io/390909


Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatar <shuhei.matsumoto.xt@hitachi.com>
parent 0709cc48

test/unit/lib/iscsi/tgt_node.c/tgt_node_ut.c

+10 −4
Original line number Diff line number Diff line
@@ -333,14 +333,14 @@ node_access_multi_initiator_groups_cases(void) 
	strncpy(scsi_dev.name, IQN1, SPDK_SCSI_DEV_MAX_NAME);

	tgtnode.dev = &scsi_dev;



	pg_map = spdk_iscsi_tgt_node_add_pg_map(&tgtnode, &pg);

	spdk_iscsi_pg_map_add_ig_map(pg_map, &ig1);

	spdk_iscsi_pg_map_add_ig_map(pg_map, &ig2);



	/* portal group initialization */

	memset(&pg, 0, sizeof(struct spdk_iscsi_portal_grp));

	pg.tag = 1;



	pg_map = spdk_iscsi_tgt_node_add_pg_map(&tgtnode, &pg);

	spdk_iscsi_pg_map_add_ig_map(pg_map, &ig1);

	spdk_iscsi_pg_map_add_ig_map(pg_map, &ig2);



	/* portal initialization */

	memset(&portal, 0, sizeof(struct spdk_iscsi_portal));

	portal.group = &pg;
@@ -583,6 +583,12 @@ allow_iscsi_name_multi_maps_case(void) 
	strncpy(scsi_dev.name, IQN1, SPDK_SCSI_DEV_MAX_NAME);

	tgtnode.dev = &scsi_dev;



	/* portal group initialization */

	memset(&pg1, 0, sizeof(struct spdk_iscsi_portal_grp));

	pg1.tag = 1;

	memset(&pg2, 0, sizeof(struct spdk_iscsi_portal_grp));

	pg2.tag = 1;



	pg_map1 = spdk_iscsi_tgt_node_add_pg_map(&tgtnode, &pg1);

	pg_map2 = spdk_iscsi_tgt_node_add_pg_map(&tgtnode, &pg2);

	spdk_iscsi_pg_map_add_ig_map(pg_map1, &ig);