Commit d1ad2cc9 authored by yidong0635's avatar yidong0635 Committed by Jim Harris
Browse files

nvmf/nvmf_rpc: Remove unnecessary returns. 



These returns at the end of functions, so remove them.

Signed-off-by: default avataryidong0635 <dongx.yi@intel.com>
Change-Id: I1f54d812956727e1871f4879c8bc9a526d7d14c5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2848


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
parent 41219b2b

lib/nvmf/nvmf_rpc.c

+0 −11
Original line number Diff line number Diff line
@@ -800,7 +800,6 @@ rpc_nvmf_subsystem_add_listener(struct spdk_jsonrpc_request *request, 
	if (spdk_nvmf_subsystem_pause(subsystem, nvmf_rpc_listen_paused, ctx)) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		nvmf_rpc_listener_ctx_free(ctx);

		return;

	}

}

SPDK_RPC_REGISTER("nvmf_subsystem_add_listener", rpc_nvmf_subsystem_add_listener,
@@ -863,9 +862,7 @@ rpc_nvmf_subsystem_remove_listener(struct spdk_jsonrpc_request *request, 
	if (spdk_nvmf_subsystem_pause(subsystem, nvmf_rpc_listen_paused, ctx)) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		nvmf_rpc_listener_ctx_free(ctx);

		return;

	}



}

SPDK_RPC_REGISTER("nvmf_subsystem_remove_listener", rpc_nvmf_subsystem_remove_listener,

		  SPDK_RPC_RUNTIME);
@@ -994,7 +991,6 @@ resume: 
	if (spdk_nvmf_subsystem_resume(subsystem, nvmf_rpc_ns_resumed, ctx)) {

		spdk_jsonrpc_send_error_response(ctx->request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		nvmf_rpc_ns_ctx_free(ctx);

		return;

	}

}
@@ -1044,7 +1040,6 @@ rpc_nvmf_subsystem_add_ns(struct spdk_jsonrpc_request *request, 
	if (spdk_nvmf_subsystem_pause(subsystem, nvmf_rpc_ns_paused, ctx)) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		nvmf_rpc_ns_ctx_free(ctx);

		return;

	}

}

SPDK_RPC_REGISTER("nvmf_subsystem_add_ns", rpc_nvmf_subsystem_add_ns, SPDK_RPC_RUNTIME)
@@ -1112,7 +1107,6 @@ nvmf_rpc_remove_ns_paused(struct spdk_nvmf_subsystem *subsystem, 
			spdk_jsonrpc_send_error_response(ctx->request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		}

		nvmf_rpc_remove_ns_ctx_free(ctx);

		return;

	}

}
@@ -1162,7 +1156,6 @@ rpc_nvmf_subsystem_remove_ns(struct spdk_jsonrpc_request *request, 
	if (spdk_nvmf_subsystem_pause(subsystem, nvmf_rpc_remove_ns_paused, ctx)) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		nvmf_rpc_remove_ns_ctx_free(ctx);

		return;

	}

}

SPDK_RPC_REGISTER("nvmf_subsystem_remove_ns", rpc_nvmf_subsystem_remove_ns, SPDK_RPC_RUNTIME)
@@ -1252,7 +1245,6 @@ nvmf_rpc_host_paused(struct spdk_nvmf_subsystem *subsystem, 
			spdk_jsonrpc_send_error_response(ctx->request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		}

		nvmf_rpc_host_ctx_free(ctx);

		return;

	}

}
@@ -1303,7 +1295,6 @@ rpc_nvmf_subsystem_add_host(struct spdk_jsonrpc_request *request, 
	if (spdk_nvmf_subsystem_pause(subsystem, nvmf_rpc_host_paused, ctx)) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		nvmf_rpc_host_ctx_free(ctx);

		return;

	}

}

SPDK_RPC_REGISTER("nvmf_subsystem_add_host", rpc_nvmf_subsystem_add_host, SPDK_RPC_RUNTIME)
@@ -1355,7 +1346,6 @@ rpc_nvmf_subsystem_remove_host(struct spdk_jsonrpc_request *request, 
	if (spdk_nvmf_subsystem_pause(subsystem, nvmf_rpc_host_paused, ctx)) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		nvmf_rpc_host_ctx_free(ctx);

		return;

	}

}

SPDK_RPC_REGISTER("nvmf_subsystem_remove_host", rpc_nvmf_subsystem_remove_host,
@@ -1415,7 +1405,6 @@ rpc_nvmf_subsystem_allow_any_host(struct spdk_jsonrpc_request *request, 
	if (spdk_nvmf_subsystem_pause(subsystem, nvmf_rpc_host_paused, ctx)) {

		spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, "Internal error");

		nvmf_rpc_host_ctx_free(ctx);

		return;

	}

}

SPDK_RPC_REGISTER("nvmf_subsystem_allow_any_host", rpc_nvmf_subsystem_allow_any_host,