Commit 41219b2b authored by Ziye Yang's avatar Ziye Yang Committed by Jim Harris
Browse files

iscsi: Add DataSequenceInOrder in discovery_ignored_param 



The implementation of Calsoft case tc_login_29_1
is wrong. We should return "Irrelevant" to the initiator
when Session type is discovery.

Also also update the known failure test cases of
Calsoft.

Fixes 958.

Signed-off-by: default avatarZiye Yang <ziye.yang@intel.com>
Change-Id: I38cd2cf39bf80fd025ab74bc9dfe6ac412d01328
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2846


Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent b7200d0e

lib/iscsi/param.c

+1 −0
Original line number Diff line number Diff line
@@ -514,6 +514,7 @@ static const char *discovery_ignored_param[] = { 
	"FirstBurstLength"

	"MaxOutstandingR2T",

	"DataPDUInOrder",

	"DataSequenceInOrder",

	NULL,

};

test/iscsi_tgt/calsoft/calsoft.py

+7 −1
Original line number Diff line number Diff line
@@ -28,11 +28,17 @@ A standard-label MUST begin with a capital letter and must not exceed 
63 characters.

key name: A standard-label

'''

'''

06/10/2020 add tc_login_29_1 to known_failed_cases

RFC 3720 12.19. DataSequenceInOrder

Irrelevant when: SessionType=Discovery

'''



known_failed_cases = ['tc_ffp_15_2', 'tc_ffp_29_2', 'tc_ffp_29_3', 'tc_ffp_29_4',

                      'tc_err_1_1', 'tc_err_1_2', 'tc_err_2_8',

                      'tc_err_3_1', 'tc_err_3_2', 'tc_err_3_3',

                      'tc_err_3_4', 'tc_err_5_1', 'tc_login_3_1',

                      'tc_login_11_2', 'tc_login_11_4', 'tc_login_2_2']

                      'tc_login_11_2', 'tc_login_11_4', 'tc_login_2_2', 'tc_login_29_1']





def run_case(case, result_list, log_dir_path):