Commit c2e259bd authored by Boris Glimcher's avatar Boris Glimcher Committed by Tomasz Zawadzki
Browse files

schema: fix mismatched boolean parameters 



previous patches ignored boolean types

Change-Id: I3b7d0540ced54f980e1e94be279c035d98cb4253
Signed-off-by: default avatarBoris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26885


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
parent dfa8ae10

python/spdk/cli/bdev.py

+2 −2
Original line number Diff line number Diff line
@@ -478,7 +478,7 @@ def add_parser(subparsers): 
        args.client.bdev_nvme_set_hotplug(enable=args.enable, period_us=args.period_us)



    p = subparsers.add_parser('bdev_nvme_set_hotplug', help='Set hotplug options for bdev nvme type.')

    group = p.add_mutually_exclusive_group()

    group = p.add_mutually_exclusive_group(required=True)

    group.add_argument('-d', '--disable', dest='enable', action='store_false', help="Disable hotplug (default)", default=False)

    group.add_argument('-e', '--enable',  dest='enable', action='store_true', help="Enable hotplug")

    p.add_argument('-r', '--period-us',
@@ -1052,7 +1052,7 @@ def add_parser(subparsers): 


    p = subparsers.add_parser('bdev_enable_histogram',

                              help='Enable or disable histogram for specified bdev')

    group = p.add_mutually_exclusive_group()

    group = p.add_mutually_exclusive_group(required=True)

    group.add_argument('-e', '--enable',  dest='enable', action='store_true', help='Enable histograms on specified device', default=True)

    group.add_argument('-d', '--disable', dest='enable', action='store_false', help='Disable histograms on specified device')

    p.add_argument('-o', '--opc', help='Enable histogram for specified io type. Defaults to all io types if not specified.'

python/spdk/cli/iscsi.py

+1 −1
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 


    p = subparsers.add_parser('iscsi_enable_histogram',

                              help='Enable or disable histogram for specified iscsi target')

    group = p.add_mutually_exclusive_group()

    group = p.add_mutually_exclusive_group(required=True)

    group.add_argument('-e', '--enable', dest='enable', action='store_true',

                       help='Enable histograms on specified iscsi target', default=True)

    group.add_argument('-d', '--disable', dest='enable', action='store_false',

python/spdk/cli/log.py

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ def add_parser(subparsers): 
        ret = args.client.log_enable_timestamps(enabled=args.enabled)

    p = subparsers.add_parser('log_enable_timestamps',

                              help='Enable or disable timestamps.')

    group = p.add_mutually_exclusive_group()

    group = p.add_mutually_exclusive_group(required=True)

    group.add_argument('-d', '--disable', dest='enabled', action='store_false', help="Disable timestamps", default=False)

    group.add_argument('-e', '--enable',  dest='enabled', action='store_true', help="Enable timestamps")

    p.set_defaults(func=log_enable_timestamps)

python/spdk/cli/vhost.py

+2 −2
Original line number Diff line number Diff line
@@ -152,8 +152,8 @@ def add_parser(subparsers): 
        args.client.bdev_virtio_blk_set_hotplug(enable=args.enable, period_us=args.period_us)



    p = subparsers.add_parser('bdev_virtio_blk_set_hotplug', help='Set hotplug options for bdev virtio_blk type.')

    group = p.add_mutually_exclusive_group()

    group.add_argument('-d', '--disable', dest='enable', default=False, action='store_false', help="Disable hotplug (default)")

    group = p.add_mutually_exclusive_group(required=True)

    group.add_argument('-d', '--disable', dest='enable', action='store_false', help="Disable hotplug")

    group.add_argument('-e', '--enable', dest='enable', action='store_true', help="Enable hotplug")

    p.add_argument('-r', '--period-us',

                   help='How often the hotplug is processed for insert and remove events', type=int)

schema/schema.json

+30 −30
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ 
        },

        {

          "name": "hide_metadata",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Enable hide_metadata option to the bdev. Default: false"

        }
@@ -150,55 +150,55 @@ 
      "fields": [

        {

          "name": "identify_ctrlr",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables custom identify handler that reports some identify attributes from the underlying NVMe drive"

        },

        {

          "name": "identify_uuid_list",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables passthru identify UUID list (0x17 CNS) admin cmds for underlying NVMe device"

        },

        {

          "name": "get_log_page",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables passthru get log page command handlers for underlying NVMe drive (for non-fabrics related log pages)"

        },

        {

          "name": "get_set_features",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables passthru get/set_feature OPC handlers for underlying NVMe drive"

        },

        {

          "name": "sanitize",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables passthru sanitize OPC handlers for underlying NVMe drive"

        },

        {

          "name": "security_send_recv",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables passthru security send/recieve OPC handlers for underlying NVMe drive"

        },

        {

          "name": "fw_update",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables passthru firmware download/commit OPC handlers for underlying NVMe drive"

        },

        {

          "name": "nvme_mi",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables passthru NVMe-MI send/recieve OPC handlers for underlying NVMe drive"

        },

        {

          "name": "vendor_specific",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "If true, enables passthru command handlers for underlying NVMe drive for vendor specific cmds (OPCs: 0xC0-0xFF)"

        }
@@ -761,7 +761,7 @@ 
      "params": [

        {

          "name": "config_kernel_mode",

          "type": "Boolean",

          "type": "boolean",

          "required": false,

          "description": "If set, will use kernel idxd driver."

        }
@@ -900,7 +900,7 @@ 
        },

        {

          "name": "per_channel",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Display per channel data for specified block device."

        },
@@ -1684,7 +1684,7 @@ 
      "params": [

        {

          "name": "enable",

          "type": "string",

          "type": "boolean",

          "required": true,

          "description": "True to enable, false to disable"

        },
@@ -1761,25 +1761,25 @@ 
        },

        {

          "name": "prchk_reftag",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Enable checking of PI reference tag for I/O processing"

        },

        {

          "name": "prchk_guard",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Enable checking of PI guard for I/O processing"

        },

        {

          "name": "hdgst",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Enable TCP header digest"

        },

        {

          "name": "ddgst",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Enable TCP data digest"

        },
@@ -1845,7 +1845,7 @@ 
        },

        {

          "name": "allow_unrecognized_csi",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Allow attaching namespaces with unrecognized command set identifiers. These will only support NVMe passthrough."

        }
@@ -2007,7 +2007,7 @@ 
        },

        {

          "name": "wait_for_attach",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Wait to complete until all discovered NVM subsystems are attached"

        },
@@ -2629,7 +2629,7 @@ 
        },

        {

          "name": "fast_shutdown",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "When set FTL will minimize persisted data on target application shutdown and rely on shared memory during next load"

        },
@@ -2682,7 +2682,7 @@ 
        },

        {

          "name": "fast_shutdown",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "When set FTL will minimize persisted data on target application shutdown and rely on shared memory during next load"

        },
@@ -2705,7 +2705,7 @@ 
        },

        {

          "name": "fast_shutdown",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "When set FTL will minimize persisted data during deletion and rely on shared memory during next load"

        }
@@ -2722,7 +2722,7 @@ 
        },

        {

          "name": "fast_shutdown",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "When set FTL will minimize persisted data during deletion and rely on shared memory during next load"

        }
@@ -2931,7 +2931,7 @@ 
      "params": [

        {

          "name": "enable",

          "type": "bool",

          "type": "boolean",

          "required": true,

          "description": "Enable or disable the virtio blk hotplug monitor"

        },
@@ -3943,7 +3943,7 @@ 
        },

        {

          "name": "secure_channel",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Whether all connections immediately attempt to establish a secure channel"

        },
@@ -4038,7 +4038,7 @@ 
        },

        {

          "name": "no_auto_visible",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Namespace is not automatically visible to controllers (default: false)"

        }
@@ -4344,7 +4344,7 @@ 
        },

        {

          "name": "secure_channel",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "The connection to that discovery subsystem requires a secure channel"

        }
@@ -6219,13 +6219,13 @@ 
        },

        {

          "name": "enable_xattr",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "true to enable the extended attributes, false otherwise"

        },

        {

          "name": "enable_writeback_cache",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "true to enable the writeback cache, false otherwise"

        },
@@ -6237,7 +6237,7 @@ 
        },

        {

          "name": "skip_rw",

          "type": "bool",

          "type": "boolean",

          "required": false,

          "description": "Skip processing read and write requests and complete them successfully immediately. This is useful for benchmarking."

        }