Commit dfa8ae10 authored by Boris Glimcher's avatar Boris Glimcher Committed by Tomasz Zawadzki
Browse files

python/cli: use add_mutually_exclusive_group consistently 

previous patch https://review.spdk.io/c/spdk/spdk/+/26775


missed few locations

Change-Id: I8b459598c1551d39e04a8916dcfc09221b14ff1d
Signed-off-by: default avatarBoris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26928


Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
parent 0a920a0c

python/spdk/cli/bdev.py

+7 −6
Original line number Diff line number Diff line
@@ -460,10 +460,11 @@ def add_parser(subparsers): 
                   type=lambda d: d.split(','))

    p.add_argument('--dhchap-dhgroups', help='Comma-separated list of allowed DH-HMAC-CHAP DH groups',

                   type=lambda d: d.split(','))

    p.add_argument('--enable-rdma-umr-per-io',

    group = p.add_mutually_exclusive_group()

    group.add_argument('--enable-rdma-umr-per-io',

                       help='''Enable scatter-gather RDMA Memory Region per IO if supported by the system.''',

                       action='store_true', dest='rdma_umr_per_io')

    p.add_argument('--disable-rdma-umr-per-io',

    group.add_argument('--disable-rdma-umr-per-io',

                       help='''Disable scatter-gather RDMA Memory Region per IO.''',

                       action='store_false', dest='rdma_umr_per_io')

    p.add_argument('--tcp-connect-timeout-ms',

python/spdk/cli/sock.py

+5 −4
Original line number Diff line number Diff line
@@ -37,9 +37,10 @@ def add_parser(subparsers): 
    p.add_argument('-r', '--recv-buf-size', help='Size of receive buffer on socket in bytes', type=int)

    p.add_argument('-s', '--send-buf-size', help='Size of send buffer on socket in bytes', type=int)

    p.add_argument('-p', '--enable-placement-id', help='Option for placement-id. 0:disable,1:incoming_napi,2:incoming_cpu', type=int)

    p.add_argument('--enable-recv-pipe', help='Enable receive pipe',

    group = p.add_mutually_exclusive_group()

    group.add_argument('--enable-recv-pipe', help='Enable receive pipe',

                       action='store_true', dest='enable_recv_pipe')

    p.add_argument('--disable-recv-pipe', help='Disable receive pipe',

    group.add_argument('--disable-recv-pipe', help='Disable receive pipe',

                       action='store_false', dest='enable_recv_pipe')

    group = p.add_mutually_exclusive_group()

    group.add_argument('--enable-quickack', help='Enable quick ACK',

python/spdk/cli/vhost.py

+3 −2
Original line number Diff line number Diff line
@@ -152,8 +152,9 @@ def add_parser(subparsers): 
        args.client.bdev_virtio_blk_set_hotplug(enable=args.enable, period_us=args.period_us)



    p = subparsers.add_parser('bdev_virtio_blk_set_hotplug', help='Set hotplug options for bdev virtio_blk type.')

    p.add_argument('-d', '--disable', dest='enable', default=False, action='store_false', help="Disable hotplug (default)")

    p.add_argument('-e', '--enable', dest='enable', action='store_true', help="Enable hotplug")

    group = p.add_mutually_exclusive_group()

    group.add_argument('-d', '--disable', dest='enable', default=False, action='store_false', help="Disable hotplug (default)")

    group.add_argument('-e', '--enable', dest='enable', action='store_true', help="Enable hotplug")

    p.add_argument('-r', '--period-us',

                   help='How often the hotplug is processed for insert and remove events', type=int)

    p.set_defaults(func=bdev_virtio_blk_set_hotplug)