Commit b866d519 authored by Sochin Jiang's avatar Sochin Jiang Committed by Tomasz Zawadzki
Browse files

lib/iscsi: fix one inappropriate assertion 



Port scanning causes iscsi_tgt assertion failure, try using
'nmap -sV ${host} -p ${port}' to reproduce the assertion failure
'ahs_len <= ISCSI_AHS_LEN', fix this issue.

Signed-off-by: default avatarSochin Jiang <jiangxiaoqing.sochin@bytedance.com>
Change-Id: I3ada9f0faf746792264e0ce74eb11eebba9d9432
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4585


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent 8d081e74

lib/iscsi/iscsi.c

+6 −1
Original line number Diff line number Diff line
@@ -4597,7 +4597,12 @@ iscsi_read_pdu(struct spdk_iscsi_conn *conn) 


			/* AHS */

			ahs_len = pdu->bhs.total_ahs_len * 4;

			assert(ahs_len <= ISCSI_AHS_LEN);

			if (ahs_len > ISCSI_AHS_LEN) {

				SPDK_DEBUGLOG(SPDK_LOG_ISCSI, "pdu ahs length %d is invalid\n", ahs_len);

				conn->pdu_recv_state = ISCSI_PDU_RECV_STATE_ERROR;

				break;

			}



			if (pdu->ahs_valid_bytes < ahs_len) {

				rc = iscsi_conn_read_data(conn,

							  ahs_len - pdu->ahs_valid_bytes,