Commit 8d081e74 authored Sep 07, 2020 by Sochin Jiang Committed by Tomasz Zawadzki Oct 13, 2020

lib/iscsi: fix another assertion failure of 'assert(task->ref > 0)'



In high read IO pressure, there is a loop call of process_completed_read_subtask_list()
while calling spdk_iscsi_task_response(), this cause 'primary->bytes_completed'
changes, in turn cause multiple calls of 'spdk_iscsi_task_put(primary)', assertion
failes in spdk_scsi_task_put().

Signed-off-by: Sochin Jiang <jiangxiaoqing.sochin@bytedance.com>
Change-Id: I41d02d318f827f3bb3ad9ba3a06e080b5113cd40
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4083


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

parent eda91a7b

lib/iscsi/conn.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -1088,16 +1088,15 @@ process_completed_read_subtask_list(struct spdk_iscsi_conn *conn,
		if (subtask->scsi.offset == primary->bytes_completed) {
		TAILQ_REMOVE(&primary->subtask_list, subtask, subtask_link);
		primary->bytes_completed += subtask->scsi.length;
		if (primary->bytes_completed == primary->scsi.transfer_len) {
		iscsi_task_put(primary);
		}
		iscsi_task_response(conn, subtask);
		iscsi_task_put(subtask);
		} else {
		break;
		}
		}

		if (primary->bytes_completed == primary->scsi.transfer_len) {
		iscsi_task_put(primary);
		}
		}

		static void