Commit b2a7f2bd authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Darek Stojaczyk
Browse files

bdev/split: Improve error check of config file parsing by spdk_strtol 



Change-Id: I94abf6c3059528b84c1f8763f56891150726021a
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/c/441639


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarwuzhouhui <wuzhouhui@kingsoft.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 889abac0

lib/bdev/split/vbdev_split.c

+2 −2
Original line number Diff line number Diff line
@@ -429,7 +429,7 @@ vbdev_split_init(void) 
			goto err;

		}



		split_count = atoi(split_count_str);

		split_count = spdk_strtol(split_count_str, 10);

		if (split_count < 1) {

			SPDK_ERRLOG("Invalid Split count %d\n", split_count);

			rc = -EINVAL;
@@ -440,7 +440,7 @@ vbdev_split_init(void) 
		split_size = 0;

		split_size_str = spdk_conf_section_get_nmval(sp, "Split", i, 2);

		if (split_size_str) {

			split_size = atoi(split_size_str);

			split_size = spdk_strtol(split_size_str, 10);

			if (split_size <= 0) {

				SPDK_ERRLOG("Invalid Split size %d\n", split_size);

				rc = -EINVAL;