Commit 889abac0 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Darek Stojaczyk
Browse files

bdev/aio: Improve error check of config file parsing by spdk_strtol 



Change-Id: I6e0657c22a124e5c8773f27d40c8cdf7b35055d8
Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/c/441638


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarwuzhouhui <wuzhouhui@kingsoft.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 67b720f4

lib/bdev/aio/bdev_aio.c

+8 −1
Original line number Diff line number Diff line
@@ -686,6 +686,7 @@ bdev_aio_initialize(void) 
		const char *name;

		const char *block_size_str;

		uint32_t block_size = 0;

		long int tmp;



		file = spdk_conf_section_get_nmval(sp, "AIO", i, 0);

		if (!file) {
@@ -701,7 +702,13 @@ bdev_aio_initialize(void) 


		block_size_str = spdk_conf_section_get_nmval(sp, "AIO", i, 2);

		if (block_size_str) {

			block_size = atoi(block_size_str);

			tmp = spdk_strtol(block_size_str, 10);

			if (tmp < 0) {

				SPDK_ERRLOG("Invalid block size for AIO disk with file %s\n", file);

				i++;

				continue;

			}

			block_size = (uint32_t)tmp;

		}



		bdev = create_aio_disk(name, file, block_size);