Commit b0c97889 authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

bdevperf: clean up output 



We can make the output a bit more precise by putting
the Core Mask on the same line as the Thread Name.

Let's also use "Job Name" instead of "Thread Name"
since that more closely matches the user's intent.
We use a thread internally for each job, but user
specifies workloads in terms of jobs, not threads.

Finally let's get the Total values aligned
with the per-job values again - this seems to have
broken as part of commit d80b4f42.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I04fcd294b8f88374b11e09350aabf84beb2ae60e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6328


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Community-CI: Mellanox Build Bot
parent 933868af

test/bdev/bdevperf/bdevperf.c

+5 −5
Original line number Diff line number Diff line
@@ -226,8 +226,8 @@ performance_dump_job(struct bdevperf_aggregate_stats *stats, struct bdevperf_job 
{

	double io_per_second, mb_per_second, failed_per_second, timeout_per_second;



	printf("\r Thread name: %s\n", spdk_thread_get_name(job->thread));

	printf("\t Core Mask: 0x%s\n", spdk_cpuset_fmt(spdk_thread_get_cpumask(job->thread)));

	printf("\r Job: %s (Core Mask 0x%s)\n", spdk_thread_get_name(job->thread),

	       spdk_cpuset_fmt(spdk_thread_get_cpumask(job->thread)));

	if (job->verify) {

		printf("\t Verification LBA range: start 0x%" PRIx64 " length 0x%" PRIx64 "\n",

		       job->ios_base, job->size_in_ios);
@@ -410,11 +410,11 @@ bdevperf_test_done(void *ctx) 
		free(job);

	}



	printf("\r =====================================================\n");

	printf("\r %-20s: %10.2f IOPS %10.2f MiB/s\n",

	printf("\r =============================================================\n");

	printf("\r %-28s: %10.2f IOPS %10.2f MiB/s\n",

	       "Total", g_stats.total_io_per_second, g_stats.total_mb_per_second);

	if (g_stats.total_failed_per_second != 0 || g_stats.total_timeout_per_second != 0) {

		printf("\r %-20s: %10.2f Fail/s %8.2f TO/s\n",

		printf("\r %-28s: %10.2f Fail/s %8.2f TO/s\n",

		       "", g_stats.total_failed_per_second, g_stats.total_timeout_per_second);

	}

	fflush(stdout);