Commit 933868af authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

spdk_top: fix -h option handling 



-H is not specified to getopt, so there's no reason
to have a case statement for it.

We should also return 0 when -h is specified. spdk_top
-h should not return error status to the shell since
this is valid usage.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ifa24c93661648c61de6925bea4b4071cd53013d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6327


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatar <dongx.yi@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
parent 1ed57e1f

app/spdk_top/spdk_top.c

+1 −2
Original line number Diff line number Diff line
@@ -2468,10 +2468,9 @@ int main(int argc, char **argv) 
		case 'r':

			socket = optarg;

			break;

		case 'H':

		default:

			usage(argv[0]);

			return 1;

			return op == 'h' ? 0 : 1;

		}

	}