Commit ade76c12 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Jim Harris
Browse files

util: remove spdk_iov_one() 



It was deprecated and scheduled for removal in v24.05.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I92863b51fcc1d5bc6c646c6eff043b0c34890264
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22949


Community-CI: Mellanox Build Bot
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent 8cb95ba3

deprecation.md

+0 −7
Original line number Diff line number Diff line
@@ -34,13 +34,6 @@ Passing NVMe/TLS pre-shared keys via `spdk_nvme_ctrlr_opts.psk` is deprecated an 
removed in the v24.09 release.  Instead, a key obtained from the keyring library should be passed

in `spdk_nvme_ctrlr_opts.tls_psk`.



### util



#### `spdk_iov_one`



The function is deprecated and will be removed in 24.05 release. Please use `SPDK_IOV_ONE`

macro instead.



### init



#### `spdk_subsystem_init_from_json_config`

include/spdk/util.h

+0 −3
Original line number Diff line number Diff line
@@ -186,9 +186,6 @@ spdk_iov_memset(struct iovec *iovs, int iovcnt, int c); 
/**

 * Initialize an iovec with just the single given buffer.

 */

void

spdk_iov_one(struct iovec *iov, int *iovcnt, void *buf, size_t buflen);



#define SPDK_IOV_ONE(piov, piovcnt, buf, buflen) do {	\

	(piov)->iov_base = (buf);			\

	(piov)->iov_len = (buflen);			\

lib/util/iov.c

+0 −12
Original line number Diff line number Diff line
@@ -19,18 +19,6 @@ spdk_iov_memset(struct iovec *iovs, int iovcnt, int c) 
	}

}



SPDK_LOG_DEPRECATION_REGISTER(spdk_iov_one, "spdk_iov_one", "v24.05", 0);



void

spdk_iov_one(struct iovec *iov, int *iovcnt, void *buf, size_t buflen)

{

	SPDK_LOG_DEPRECATED(spdk_iov_one);



	iov->iov_base = buf;

	iov->iov_len = buflen;

	*iovcnt = 1;

}



size_t

spdk_ioviter_first(struct spdk_ioviter *iter,

		   struct iovec *siov, size_t siovcnt,

lib/util/spdk_util.map

+0 −1
Original line number Diff line number Diff line
@@ -147,7 +147,6 @@ 
	spdk_ioviter_firstv;

	spdk_ioviter_nextv;

	spdk_iov_memset;

	spdk_iov_one;

	spdk_iov_xfer_init;

	spdk_iov_xfer_from_buf;

	spdk_iov_xfer_to_buf;