Commit 8cb95ba3 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Jim Harris
Browse files

nvmf: remove spdk_nvmf_subsytem_any_listener_allowed() 



It was deprecated and scheduled for removal in v24.05.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2184f5521aff8580cac6b7d26ae7bb0fec490851
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22948


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent 608b54a2

deprecation.md

+0 −5
Original line number Diff line number Diff line
@@ -61,11 +61,6 @@ execute fabrics commands. 
`transport` field in `listen_addresses` of `nvmf_get_subsystems` RPC is deprecated.

`trtype` field should be used instead. `transport` field will be removed in 24.05 release.



#### `spdk_nvmf_subsytem_any_listener_allowed`



The function is deprecated and will be removed in 24.05 release. Please use

`spdk_nvmf_subsystem_any_listener_allowed` instead.



#### `nvmf_subsystem_add_host`



The ability to specifying path to a PSK file via the `psk` parameter in `nvmf_subsystem_add_host` is

include/spdk/nvmf.h

+0 −14
Original line number Diff line number Diff line
@@ -845,20 +845,6 @@ void spdk_nvmf_subsystem_allow_any_listener( 
	struct spdk_nvmf_subsystem *subsystem,

	bool allow_any_listener);



/**

 * Check whether a subsystem allows any listen address or only addresses in the allowed list.

 *

 * Deprecated - will be removed in v24.05. Please use

 * \ref spdk_nvmf_subsystem_any_listener_allowed.

 *

 * \param subsystem Subsystem to query.

 *

 * \return true if this subsystem allows dynamic management of listen address list,

 *  or false if only allows addresses in the list configured during subsystem setup.

 */

bool spdk_nvmf_subsytem_any_listener_allowed(

	struct spdk_nvmf_subsystem *subsystem);



/**

 * Check whether a subsystem allows any listen address or only addresses in the allowed list.

 *

lib/nvmf/spdk_nvmf.map

+0 −1
Original line number Diff line number Diff line
@@ -50,7 +50,6 @@ 
	spdk_nvmf_subsystem_get_next_listener;

	spdk_nvmf_subsystem_listener_get_trid;

	spdk_nvmf_subsystem_allow_any_listener;

	spdk_nvmf_subsytem_any_listener_allowed;

	spdk_nvmf_subsystem_any_listener_allowed;

	spdk_nvmf_subsystem_listener_opts_init;

	spdk_nvmf_ns_opts_get_defaults;

lib/nvmf/subsystem.c

+0 −10
Original line number Diff line number Diff line
@@ -1509,16 +1509,6 @@ spdk_nvmf_subsystem_allow_any_listener(struct spdk_nvmf_subsystem *subsystem, 
	subsystem->flags.allow_any_listener = allow_any_listener;

}



SPDK_LOG_DEPRECATION_REGISTER(spdk_nvmf_subsytem_any_listener_allowed,

			      "spdk_nvmf_subsytem_any_listener_allowed is deprecated", "v24.05", 0);



bool

spdk_nvmf_subsytem_any_listener_allowed(struct spdk_nvmf_subsystem *subsystem)

{

	SPDK_LOG_DEPRECATED(spdk_nvmf_subsytem_any_listener_allowed);

	return subsystem->flags.allow_any_listener;

}



bool

spdk_nvmf_subsystem_any_listener_allowed(struct spdk_nvmf_subsystem *subsystem)

{