Commit ab3a4655 authored Jul 30, 2020 by Seth Howell Committed by Jim Harris Aug 04, 2020

lib/bdev: fix potential mem leak in part.c



The way this is written currently, there is a
(very very unlikely) chance that the first strdup
fails and the second one succeeds. Just clean that
up.

Signed-off-by: Seth Howell <seth.howell@intel.com>
Change-Id: I5ca1106c713753448a2bf988166a2d79ab9fa86d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3610


Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent 305d6458

lib/bdev/part.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -484,12 +484,13 @@ spdk_bdev_part_construct(struct spdk_bdev_part *part, struct spdk_bdev_part_base
		part->internal.bdev.dif_check_flags = base->bdev->dif_check_flags;

		part->internal.bdev.name = strdup(name);
		part->internal.bdev.product_name = strdup(product_name);

		if (part->internal.bdev.name == NULL) {
		SPDK_ERRLOG("Failed to allocate name for new part of bdev %s\n", spdk_bdev_get_name(base->bdev));
		return -1;
		} else if (part->internal.bdev.product_name == NULL) {
		}

		part->internal.bdev.product_name = strdup(product_name);
		if (part->internal.bdev.product_name == NULL) {
		free(part->internal.bdev.name);
		SPDK_ERRLOG("Failed to allocate product name for new part of bdev %s\n",
		spdk_bdev_get_name(base->bdev));