Commit 305d6458 authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

lib/virtio: fix heap use after free issue. 



fixes 79c7744e

Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Change-Id: Ia7919b8922de7e99b0a9f5266a96940f05f4865c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3609


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent beb468e9

lib/virtio/virtio_pci.c

+5 −1
Original line number Diff line number Diff line
@@ -224,10 +224,14 @@ static void 
modern_destruct_dev(struct virtio_dev *vdev)

{

	struct virtio_hw *hw = vdev->ctx;

	struct spdk_pci_device *pci_dev;



	if (hw != NULL) {

		pci_dev = hw->pci_dev;

		free_virtio_hw(hw);

		spdk_pci_device_detach(hw->pci_dev);

		if (pci_dev) {

			spdk_pci_device_detach(pci_dev);

		}

	}

}