Commit 8df52a0f authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

lib/nvme_tcp: assert tcp_req->req before it is dereferenced 



The value of tcp_req->req was asserted after it was already
dereferenced. This patch fixes that.

Change-Id: I5eb01e88be09d41fb8e632c49d5a7ccf2315788f
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462508


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent f75d1540

lib/nvme/nvme_tcp.c

+3 −3
Original line number Diff line number Diff line
@@ -1882,11 +1882,11 @@ nvme_tcp_admin_qpair_abort_aers(struct spdk_nvme_qpair *qpair) 
	cpl.status.sct = SPDK_NVME_SCT_GENERIC;



	TAILQ_FOREACH_SAFE(tcp_req, &tqpair->outstanding_reqs, link, tmp) {

		if (tcp_req->req->cmd.opc != SPDK_NVME_OPC_ASYNC_EVENT_REQUEST) {

			continue;

		}

		assert(tcp_req->req != NULL);

		req = tcp_req->req;

		if (req->cmd.opc != SPDK_NVME_OPC_ASYNC_EVENT_REQUEST) {

			continue;

		}



		nvme_tcp_req_complete(req, &cpl);

		nvme_tcp_req_put(tqpair, tcp_req);