Commit f75d1540 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Jim Harris
Browse files

lib/ftl: check namespace for NULL during initialization 



spdk_nvme_ctrlr_get_ns() can return NULL, which was
not verified, but dereferenced anyway.

Change-Id: Ib0554148cc47ea3ff2afa1862ac962f284fe6d43
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462486


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent eb84a113

lib/ftl/ftl_init.c

+4 −0
Original line number Diff line number Diff line
@@ -477,6 +477,10 @@ ftl_dev_nvme_init(struct spdk_ftl_dev *dev, const struct spdk_ftl_dev_init_opts 
	}



	dev->ns = spdk_nvme_ctrlr_get_ns(dev->ctrlr, FTL_NSID);

	if (dev->ns == NULL) {

		SPDK_ERRLOG("Invalid NS (%"PRIu32")\n", FTL_NSID);

		return -1;

	}

	dev->trid = opts->trid;

	dev->md_size = spdk_nvme_ns_get_md_size(dev->ns);