Commit 81d3cc1b authored by wanghailiangx's avatar wanghailiangx Committed by Jim Harris
Browse files

subsystem module: remove support for deprecated RPC names 



These were deprecated in 2019, it's time to remove
support for them now.

Change-Id: I56dbaef56ff793e48441219e07dc6b02dda0b470
Signed-off-by: default avatarwanghailiangx <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12777


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 465f99e9

lib/init/subsystem_rpc.c

+0 −2
Original line number Diff line number Diff line
@@ -79,7 +79,6 @@ rpc_framework_get_subsystems(struct spdk_jsonrpc_request *request, 
}



SPDK_RPC_REGISTER("framework_get_subsystems", rpc_framework_get_subsystems, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(framework_get_subsystems, get_subsystems)



struct rpc_framework_get_config_ctx {

	char *name;
@@ -119,7 +118,6 @@ rpc_framework_get_config(struct spdk_jsonrpc_request *request, 
}



SPDK_RPC_REGISTER("framework_get_config", rpc_framework_get_config, SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(framework_get_config, get_subsystem_config)



static void

dump_pci_device(void *ctx, struct spdk_pci_device *dev)

python/spdk/rpc/subsystem.py

+0 −2
Original line number Diff line number Diff line 
from .helpers import deprecated_alias





@deprecated_alias('get_subsystems')

def framework_get_subsystems(client):

    return client.call('framework_get_subsystems')





@deprecated_alias('get_subsystem_config')

def framework_get_config(client, name):

    params = {'name': name}

    return client.call('framework_get_config', params)

scripts/rpc.py

+2 −3
Original line number Diff line number Diff line
@@ -2392,7 +2392,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
    def framework_get_subsystems(args):

        print_dict(rpc.subsystem.framework_get_subsystems(args.client))



    p = subparsers.add_parser('framework_get_subsystems', aliases=['get_subsystems'],

    p = subparsers.add_parser('framework_get_subsystems',

                              help="""Print subsystems array in initialization order. Each subsystem

    entry contain (unsorted) array of subsystems it depends on.""")

    p.set_defaults(func=framework_get_subsystems)
@@ -2400,8 +2400,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
    def framework_get_config(args):

        print_dict(rpc.subsystem.framework_get_config(args.client, args.name))



    p = subparsers.add_parser('framework_get_config', aliases=['get_subsystem_config'],

                              help="""Print subsystem configuration""")

    p = subparsers.add_parser('framework_get_config', help="""Print subsystem configuration""")

    p.add_argument('name', help='Name of subsystem to query')

    p.set_defaults(func=framework_get_config)