Commit 465f99e9 authored by wanghailiangx's avatar wanghailiangx Committed by Jim Harris
Browse files

accel module: remove support for deprecated RPC names 



These were deprecated in 2019, it's time to remove
support for them now.

Change-Id: I5a715e9b9e991c6febec5e505384728281eee8b7
Signed-off-by: default avatarwanghailiangx <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12773


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 25114fce

module/accel/ioat/accel_engine_ioat_rpc.c

+0 −2
Original line number Diff line number Diff line
@@ -53,5 +53,3 @@ rpc_ioat_scan_accel_engine(struct spdk_jsonrpc_request *request, 
	spdk_jsonrpc_send_bool_response(request, true);

}

SPDK_RPC_REGISTER("ioat_scan_accel_engine", rpc_ioat_scan_accel_engine, SPDK_RPC_STARTUP)
 
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(ioat_scan_accel_engine, ioat_scan_copy_engine)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(ioat_scan_accel_engine, scan_ioat_copy_engine)

python/spdk/rpc/ioat.py

+0 −2
Original line number Diff line number Diff line 
from .helpers import deprecated_alias





@deprecated_alias('ioat_scan_copy_engine')

@deprecated_alias('scan_ioat_copy_engine')

def ioat_scan_accel_engine(client):

    """Enable IOAT accel engine.

    """

scripts/bash-completion/spdk

+1 −1
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ _get_default_rpc_methods() { 
	while read -r; do

		# Each method name seems to be prefixed with 20h x 4. Then it can

		# be followed with list of aliases enclosed inside (). Example:

		#    ioat_scan_accel_engine (ioat_scan_copy_engine, scan_ioat_copy_engine)

		#    ioat_scan_accel_engine

		[[ $REPLY =~ ^\ {4}([a-z]+(_[a-z]+)*)(\ *\((.+)\))? ]] || continue



		names=("${BASH_REMATCH[1]}")

scripts/rpc.py

+1 −3
Original line number Diff line number Diff line
@@ -2538,9 +2538,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
    def ioat_scan_accel_engine(args):

        rpc.ioat.ioat_scan_accel_engine(args.client)



    p = subparsers.add_parser('ioat_scan_accel_engine',

                              aliases=['ioat_scan_copy_engine', 'scan_ioat_copy_engine'],

                              help='Enable IOAT accel engine offload.')

    p = subparsers.add_parser('ioat_scan_accel_engine', help='Enable IOAT accel engine offload.')

    p.set_defaults(func=ioat_scan_accel_engine)



    # dsa