Commit 79e2a56f authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Jim Harris
Browse files

accel: remove flags 



They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22950


Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
parent ade76c12

deprecation.md

+0 −7
Original line number Diff line number Diff line
@@ -19,13 +19,6 @@ The tags can be matched with the level 4 headers below. 


## Deprecation Notices



### accel



#### `accel_flags`



The `int flags` parameter in various *submit* and *append* accel FW API is not used and deprecated. It will be removed

in 24.05 release.



### nvme



#### `spdk_nvme_ctrlr_opts.psk`

examples/accel/perf/accel_perf.c

+7 −8
Original line number Diff line number Diff line
@@ -568,19 +568,18 @@ _submit_single(struct worker_thread *worker, struct ap_task *task) 
{

	int random_num;

	int rc = 0;

	int flags = 0;



	assert(worker);



	switch (worker->workload) {

	case SPDK_ACCEL_OPC_COPY:

		rc = spdk_accel_submit_copy(worker->ch, task->dst, task->src,

					    g_xfer_size_bytes, flags, accel_done, task);

					    g_xfer_size_bytes, accel_done, task);

		break;

	case SPDK_ACCEL_OPC_FILL:

		/* For fill use the first byte of the task->dst buffer */

		rc = spdk_accel_submit_fill(worker->ch, task->dst, *(uint8_t *)task->src,

					    g_xfer_size_bytes, flags, accel_done, task);

					    g_xfer_size_bytes, accel_done, task);

		break;

	case SPDK_ACCEL_OPC_CRC32C:

		rc = spdk_accel_submit_crc32cv(worker->ch, task->crc_dst,
@@ -589,7 +588,7 @@ _submit_single(struct worker_thread *worker, struct ap_task *task) 
		break;

	case SPDK_ACCEL_OPC_COPY_CRC32C:

		rc = spdk_accel_submit_copy_crc32cv(worker->ch, task->dst, task->src_iovs, task->src_iovcnt,

						    task->crc_dst, g_crc32c_seed, flags, accel_done, task);

						    task->crc_dst, g_crc32c_seed, accel_done, task);

		break;

	case SPDK_ACCEL_OPC_COMPARE:

		random_num = rand() % 100;
@@ -605,20 +604,20 @@ _submit_single(struct worker_thread *worker, struct ap_task *task) 
		break;

	case SPDK_ACCEL_OPC_DUALCAST:

		rc = spdk_accel_submit_dualcast(worker->ch, task->dst, task->dst2,

						task->src, g_xfer_size_bytes, flags, accel_done, task);

						task->src, g_xfer_size_bytes, accel_done, task);

		break;

	case SPDK_ACCEL_OPC_COMPRESS:

		task->src_iovs = task->cur_seg->uncompressed_iovs;

		task->src_iovcnt = task->cur_seg->uncompressed_iovcnt;

		rc = spdk_accel_submit_compress(worker->ch, task->dst, task->cur_seg->compressed_len_padded,

						task->src_iovs,

						task->src_iovcnt, &task->compressed_sz, flags, accel_done, task);

						task->src_iovcnt, &task->compressed_sz, accel_done, task);

		break;

	case SPDK_ACCEL_OPC_DECOMPRESS:

		task->src_iovs = task->cur_seg->compressed_iovs;

		task->src_iovcnt = task->cur_seg->compressed_iovcnt;

		rc = spdk_accel_submit_decompress(worker->ch, task->dst_iovs, task->dst_iovcnt, task->src_iovs,

						  task->src_iovcnt, NULL, flags, accel_done, task);

						  task->src_iovcnt, NULL, accel_done, task);

		break;

	case SPDK_ACCEL_OPC_XOR:

		rc = spdk_accel_submit_xor(worker->ch, task->dst, task->sources, g_xor_src_count,
@@ -1216,7 +1215,7 @@ accel_perf_prep_process_seg(struct accel_perf_prep_ctx *ctx) 
	 * but real applications may want to consider a more sophisticated method.

	 */

	rc = spdk_accel_submit_compress(ctx->ch, seg->compressed_data, seg->compressed_len_padded, iov, 1,

					&seg->compressed_len, 0, accel_perf_prep_process_seg_cpl, ctx);

					&seg->compressed_len, accel_perf_prep_process_seg_cpl, ctx);

	if (rc < 0) {

		fprintf(stderr, "error (%d) on initial compress submission\n", rc);

		goto error;

include/spdk/accel.h

+14 −28
Original line number Diff line number Diff line
@@ -125,14 +125,13 @@ struct spdk_accel_crypto_key *spdk_accel_crypto_key_get(const char *name); 
 * \param dst Destination to copy to.

 * \param src Source to copy from.

 * \param nbytes Length in bytes to copy.

 * \param flags Accel framework flags for operations.

 * \param cb_fn Called when this copy operation completes.

 * \param cb_arg Callback argument.

 *

 * \return 0 on success, negative errno on failure.

 */

int spdk_accel_submit_copy(struct spdk_io_channel *ch, void *dst, void *src, uint64_t nbytes,

			   int flags, spdk_accel_completion_cb cb_fn, void *cb_arg);

			   spdk_accel_completion_cb cb_fn, void *cb_arg);



/**

 * Submit a dual cast copy request.
@@ -142,14 +141,13 @@ int spdk_accel_submit_copy(struct spdk_io_channel *ch, void *dst, void *src, uin 
 * \param dst2 Second destination to copy to (must be 4K aligned).

 * \param src Source to copy from.

 * \param nbytes Length in bytes to copy.

 * \param flags Accel framework flags for operations.

 * \param cb_fn Called when this copy operation completes.

 * \param cb_arg Callback argument.

 *

 * \return 0 on success, negative errno on failure.

 */

int spdk_accel_submit_dualcast(struct spdk_io_channel *ch, void *dst1, void *dst2, void *src,

			       uint64_t nbytes, int flags, spdk_accel_completion_cb cb_fn, void *cb_arg);

			       uint64_t nbytes, spdk_accel_completion_cb cb_fn, void *cb_arg);



/**

 * Submit a compare request.
@@ -175,14 +173,13 @@ int spdk_accel_submit_compare(struct spdk_io_channel *ch, void *src1, void *src2 
 * \param dst Destination to fill.

 * \param fill Constant byte to fill to the destination.

 * \param nbytes Length in bytes to fill.

 * \param flags Accel framework flags for operations.

 * \param cb_fn Called when this fill operation completes.

 * \param cb_arg Callback argument.

 *

 * \return 0 on success, negative errno on failure.

 */

int spdk_accel_submit_fill(struct spdk_io_channel *ch, void *dst, uint8_t fill, uint64_t nbytes,

			   int flags, spdk_accel_completion_cb cb_fn, void *cb_arg);

			   spdk_accel_completion_cb cb_fn, void *cb_arg);



/**

 * Submit a CRC-32C calculation request.
@@ -232,14 +229,13 @@ int spdk_accel_submit_crc32cv(struct spdk_io_channel *ch, uint32_t *crc_dst, str 
 * \param crc_dst Destination to write the CRC-32C to.

 * \param seed Four byte seed value.

 * \param nbytes Length in bytes.

 * \param flags Accel framework flags for operations.

 * \param cb_fn Called when this CRC-32C operation completes.

 * \param cb_arg Callback argument.

 *

 * \return 0 on success, negative errno on failure.

 */

int spdk_accel_submit_copy_crc32c(struct spdk_io_channel *ch, void *dst, void *src,

				  uint32_t *crc_dst, uint32_t seed, uint64_t nbytes, int flags,

				  uint32_t *crc_dst, uint32_t seed, uint64_t nbytes,

				  spdk_accel_completion_cb cb_fn, void *cb_arg);



/**
@@ -253,7 +249,6 @@ int spdk_accel_submit_copy_crc32c(struct spdk_io_channel *ch, void *dst, void *s 
 * \param iovcnt The size of the io vectors.

 * \param crc_dst Destination to write the CRC-32C to.

 * \param seed Four byte seed value.

 * \param flags Accel framework flags for operations.

 * \param cb_fn Called when this CRC-32C operation completes.

 * \param cb_arg Callback argument.

 *
@@ -261,7 +256,7 @@ int spdk_accel_submit_copy_crc32c(struct spdk_io_channel *ch, void *dst, void *s 
 */

int spdk_accel_submit_copy_crc32cv(struct spdk_io_channel *ch, void *dst, struct iovec *src_iovs,

				   uint32_t iovcnt, uint32_t *crc_dst, uint32_t seed,

				   int flags, spdk_accel_completion_cb cb_fn, void *cb_arg);

				   spdk_accel_completion_cb cb_fn, void *cb_arg);



/**

 * Build and submit a memory compress request.
@@ -274,7 +269,6 @@ int spdk_accel_submit_copy_crc32cv(struct spdk_io_channel *ch, void *dst, struct 
 * \param src_iovs The io vector array which stores the src data and len.

 * \param src_iovcnt The size of the src io vectors.

 * \param output_size The size of the compressed data (may be NULL if not desired)

 * \param flags Flags, optional flags that can vary per operation.

 * \param cb_fn Callback function which will be called when the request is complete.

 * \param cb_arg Opaque value which will be passed back as the arg parameter in

 * the completion callback.
@@ -283,7 +277,7 @@ int spdk_accel_submit_copy_crc32cv(struct spdk_io_channel *ch, void *dst, struct 
 */

int spdk_accel_submit_compress(struct spdk_io_channel *ch, void *dst,

			       uint64_t nbytes, struct iovec *src_iovs,

			       size_t src_iovcnt, uint32_t *output_size, int flags,

			       size_t src_iovcnt, uint32_t *output_size,

			       spdk_accel_completion_cb cb_fn, void *cb_arg);



/**
@@ -297,7 +291,6 @@ int spdk_accel_submit_compress(struct spdk_io_channel *ch, void *dst, 
 * \param src_iovs The io vector array which stores the src data and len.

 * \param src_iovcnt The size of the src io vectors.

 * \param output_size The size of the compressed data (may be NULL if not desired)

 * \param flags Flags, optional flags that can vary per operation.

 * \param cb_fn Callback function which will be called when the request is complete.

 * \param cb_arg Opaque value which will be passed back as the arg parameter in

 * the completion callback.
@@ -306,7 +299,7 @@ int spdk_accel_submit_compress(struct spdk_io_channel *ch, void *dst, 
 */

int spdk_accel_submit_decompress(struct spdk_io_channel *ch, struct iovec *dst_iovs,

				 size_t dst_iovcnt, struct iovec *src_iovs,

				 size_t src_iovcnt, uint32_t *output_size, int flags,

				 size_t src_iovcnt, uint32_t *output_size,

				 spdk_accel_completion_cb cb_fn, void *cb_arg);



/**
@@ -343,7 +336,6 @@ int spdk_accel_submit_xor(struct spdk_io_channel *ch, void *dst, void **sources, 
 * \param iv Initialization vector (tweak) used for encryption

 * \param block_size Logical block size, if src contains more than 1 logical block, subsequent

 *        logical blocks will be encrypted with incremented \b iv

 * \param flags Accel framework flags for operations.

 * \param cb_fn Callback function which will be called when the request is complete.

 * \param cb_arg Opaque value which will be passed back as the arg parameter in the completion

 *        callback.
@@ -353,7 +345,7 @@ int spdk_accel_submit_xor(struct spdk_io_channel *ch, void *dst, void **sources, 
int spdk_accel_submit_encrypt(struct spdk_io_channel *ch, struct spdk_accel_crypto_key *key,

			      struct iovec *dst_iovs, uint32_t dst_iovcnt,

			      struct iovec *src_iovs, uint32_t src_iovcnt,

			      uint64_t iv, uint32_t block_size, int flags,

			      uint64_t iv, uint32_t block_size,

			      spdk_accel_completion_cb cb_fn, void *cb_arg);



/**
@@ -375,7 +367,6 @@ int spdk_accel_submit_encrypt(struct spdk_io_channel *ch, struct spdk_accel_cryp 
 *        encryption of a data block

 * \param block_size Logical block size, if src contains more than 1 logical block, subsequent

 *        logical blocks will be decrypted with incremented \b iv

 * \param flags Accel framework flags for operations.

 * \param cb_fn Callback function which will be called when the request is complete.

 * \param cb_arg Opaque value which will be passed back as the arg parameter in the completion

 *        callback.
@@ -385,7 +376,7 @@ int spdk_accel_submit_encrypt(struct spdk_io_channel *ch, struct spdk_accel_cryp 
int spdk_accel_submit_decrypt(struct spdk_io_channel *ch, struct spdk_accel_crypto_key *key,

			      struct iovec *dst_iovs, uint32_t dst_iovcnt,

			      struct iovec *src_iovs, uint32_t src_iovcnt,

			      uint64_t iv, uint32_t block_size, int flags,

			      uint64_t iv, uint32_t block_size,

			      spdk_accel_completion_cb cb_fn, void *cb_arg);



/**
@@ -490,7 +481,6 @@ typedef void (*spdk_accel_step_cb)(void *cb_arg); 
 * \param src_iovcnt Size of the `src_iovs` array.

 * \param src_domain Memory domain to which the source buffers belong.

 * \param src_domain_ctx Source buffer domain context.

 * \param flags Accel operation flags.

 * \param cb_fn Callback to be executed once this operation is completed.

 * \param cb_arg Argument to be passed to `cb_fn`.

 *
@@ -501,7 +491,7 @@ int spdk_accel_append_copy(struct spdk_accel_sequence **seq, struct spdk_io_chan 
			   struct spdk_memory_domain *dst_domain, void *dst_domain_ctx,

			   struct iovec *src_iovs, uint32_t src_iovcnt,

			   struct spdk_memory_domain *src_domain, void *src_domain_ctx,

			   int flags, spdk_accel_step_cb cb_fn, void *cb_arg);

			   spdk_accel_step_cb cb_fn, void *cb_arg);



/**

 * Append a fill operation to a sequence.
@@ -513,7 +503,6 @@ int spdk_accel_append_copy(struct spdk_accel_sequence **seq, struct spdk_io_chan 
 * \param domain Memory domain to which the data buffer belongs.

 * \param domain_ctx Buffer domain context.

 * \param pattern Pattern to fill the buffer with.

 * \param flags Accel operation flags.

 * \param cb_fn Callback to be executed once this operation is completed.

 * \param cb_arg Argument to be passed to `cb_fn`.

 *
@@ -522,7 +511,7 @@ int spdk_accel_append_copy(struct spdk_accel_sequence **seq, struct spdk_io_chan 
int spdk_accel_append_fill(struct spdk_accel_sequence **seq, struct spdk_io_channel *ch,

			   void *buf, uint64_t len,

			   struct spdk_memory_domain *domain, void *domain_ctx, uint8_t pattern,

			   int flags, spdk_accel_step_cb cb_fn, void *cb_arg);

			   spdk_accel_step_cb cb_fn, void *cb_arg);



/**

 * Append a decompress operation to a sequence.
@@ -537,7 +526,6 @@ int spdk_accel_append_fill(struct spdk_accel_sequence **seq, struct spdk_io_chan 
 * \param src_iovcnt Size of the `src_iovs` array.

 * \param src_domain Memory domain to which the source buffers belong.

 * \param src_domain_ctx Source buffer domain context.

 * \param flags Accel operation flags.

 * \param cb_fn Callback to be executed once this operation is completed.

 * \param cb_arg Argument to be passed to `cb_fn`.

 *
@@ -548,7 +536,7 @@ int spdk_accel_append_decompress(struct spdk_accel_sequence **seq, struct spdk_i 
				 struct spdk_memory_domain *dst_domain, void *dst_domain_ctx,

				 struct iovec *src_iovs, size_t src_iovcnt,

				 struct spdk_memory_domain *src_domain, void *src_domain_ctx,

				 int flags, spdk_accel_step_cb cb_fn, void *cb_arg);

				 spdk_accel_step_cb cb_fn, void *cb_arg);



/**

 * Append an encrypt operation to a sequence.
@@ -572,7 +560,6 @@ int spdk_accel_append_decompress(struct spdk_accel_sequence **seq, struct spdk_i 
 * \param iv Initialization vector (tweak) used for encryption

 * \param block_size Logical block size, if src contains more than 1 logical block, subsequent

 *        logical blocks will be encrypted with incremented `iv`.

 * \param flags Accel operation flags.

 * \param cb_fn Callback to be executed once this operation is completed.

 * \param cb_arg Argument to be passed to `cb_fn`.

 *
@@ -584,7 +571,7 @@ int spdk_accel_append_encrypt(struct spdk_accel_sequence **seq, struct spdk_io_c 
			      struct spdk_memory_domain *dst_domain, void *dst_domain_ctx,

			      struct iovec *src_iovs, uint32_t src_iovcnt,

			      struct spdk_memory_domain *src_domain, void *src_domain_ctx,

			      uint64_t iv, uint32_t block_size, int flags,

			      uint64_t iv, uint32_t block_size,

			      spdk_accel_step_cb cb_fn, void *cb_arg);



/**
@@ -610,7 +597,6 @@ int spdk_accel_append_encrypt(struct spdk_accel_sequence **seq, struct spdk_io_c 
 *        encryption of a data block.

 * \param block_size Logical block size, if src contains more than 1 logical block, subsequent

 *        logical blocks will be decrypted with incremented `iv`.

 * \param flags Accel operation flags.

 * \param cb_fn Callback to be executed once this operation is completed.

 * \param cb_arg Argument to be passed to `cb_fn`.

 *
@@ -622,7 +608,7 @@ int spdk_accel_append_decrypt(struct spdk_accel_sequence **seq, struct spdk_io_c 
			      struct spdk_memory_domain *dst_domain, void *dst_domain_ctx,

			      struct iovec *src_iovs, uint32_t src_iovcnt,

			      struct spdk_memory_domain *src_domain, void *src_domain_ctx,

			      uint64_t iv, uint32_t block_size, int flags,

			      uint64_t iv, uint32_t block_size,

			      spdk_accel_step_cb cb_fn, void *cb_arg);



/**

include/spdk/accel_module.h

+1 −1
Original line number Diff line number Diff line
@@ -93,9 +93,9 @@ struct spdk_accel_task { 
	STAILQ_ENTRY(spdk_accel_task)	link;

	/* Uses enum spdk_accel_opcode */

	uint8_t				op_code;

	uint8_t				flags;

	bool				has_aux;

	int16_t				status;

	uint8_t				reserved[4];

	struct accel_io_channel		*accel_ch;

	struct spdk_accel_sequence	*seq;

	union {

lib/accel/accel.c

+14 −47
Original line number Diff line number Diff line
@@ -372,26 +372,10 @@ do { \ 
        (task)->has_aux = true;							\

} while (0)



SPDK_LOG_DEPRECATION_REGISTER(accel_flags,

			      "The flags parameter is unused and deprecated",

			      "v24.05", 0);



/* \b `flags` is int in API, since it is not used anywahere. we narrowed it down to uint8_t internally

 * To prevent possible problems in the future, add a macro which checks that the value of `flags` passed in the API

 * doesn't exceed 1 byte. */

#define ACCEL_ASSIGN_FLAGS(task, flags)							\

do {											\

	assert(((flags) & (~0xff)) == 0 && "task::flags needs to be extended");		\

	(task)->flags = (uint8_t)(flags);						\

	if ((task)->flags) {								\

		SPDK_LOG_DEPRECATED(accel_flags);					\

	}										\

} while (0)										\



/* Accel framework public API for copy function */

int

spdk_accel_submit_copy(struct spdk_io_channel *ch, void *dst, void *src,

		       uint64_t nbytes, int flags, spdk_accel_completion_cb cb_fn, void *cb_arg)

		       uint64_t nbytes, spdk_accel_completion_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);

	struct spdk_accel_task *accel_task;
@@ -415,7 +399,6 @@ spdk_accel_submit_copy(struct spdk_io_channel *ch, void *dst, void *src, 
	accel_task->op_code = SPDK_ACCEL_OPC_COPY;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}
@@ -423,7 +406,7 @@ spdk_accel_submit_copy(struct spdk_io_channel *ch, void *dst, void *src, 
/* Accel framework public API for dual cast copy function */

int

spdk_accel_submit_dualcast(struct spdk_io_channel *ch, void *dst1,

			   void *dst2, void *src, uint64_t nbytes, int flags,

			   void *dst2, void *src, uint64_t nbytes,

			   spdk_accel_completion_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
@@ -457,7 +440,6 @@ spdk_accel_submit_dualcast(struct spdk_io_channel *ch, void *dst1, 
	accel_task->op_code = SPDK_ACCEL_OPC_DUALCAST;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}
@@ -491,7 +473,6 @@ spdk_accel_submit_compare(struct spdk_io_channel *ch, void *src1, 
	accel_task->op_code = SPDK_ACCEL_OPC_COMPARE;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	accel_task->flags = 0;



	return accel_submit_task(accel_ch, accel_task);

}
@@ -499,7 +480,7 @@ spdk_accel_submit_compare(struct spdk_io_channel *ch, void *src1, 
/* Accel framework public API for fill function */

int

spdk_accel_submit_fill(struct spdk_io_channel *ch, void *dst,

		       uint8_t fill, uint64_t nbytes, int flags,

		       uint8_t fill, uint64_t nbytes,

		       spdk_accel_completion_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
@@ -521,7 +502,6 @@ spdk_accel_submit_fill(struct spdk_io_channel *ch, void *dst, 
	accel_task->op_code = SPDK_ACCEL_OPC_FILL;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}
@@ -552,7 +532,6 @@ spdk_accel_submit_crc32c(struct spdk_io_channel *ch, uint32_t *crc_dst, 
	accel_task->op_code = SPDK_ACCEL_OPC_CRC32C;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	accel_task->flags = 0;



	return accel_submit_task(accel_ch, accel_task);

}
@@ -591,7 +570,6 @@ spdk_accel_submit_crc32cv(struct spdk_io_channel *ch, uint32_t *crc_dst, 
	accel_task->op_code = SPDK_ACCEL_OPC_CRC32C;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	accel_task->flags = 0;



	return accel_submit_task(accel_ch, accel_task);

}
@@ -600,7 +578,7 @@ spdk_accel_submit_crc32cv(struct spdk_io_channel *ch, uint32_t *crc_dst, 
int

spdk_accel_submit_copy_crc32c(struct spdk_io_channel *ch, void *dst,

			      void *src, uint32_t *crc_dst, uint32_t seed, uint64_t nbytes,

			      int flags, spdk_accel_completion_cb cb_fn, void *cb_arg)

			      spdk_accel_completion_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);

	struct spdk_accel_task *accel_task;
@@ -626,7 +604,6 @@ spdk_accel_submit_copy_crc32c(struct spdk_io_channel *ch, void *dst, 
	accel_task->op_code = SPDK_ACCEL_OPC_COPY_CRC32C;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}
@@ -635,7 +612,7 @@ spdk_accel_submit_copy_crc32c(struct spdk_io_channel *ch, void *dst, 
int

spdk_accel_submit_copy_crc32cv(struct spdk_io_channel *ch, void *dst,

			       struct iovec *src_iovs, uint32_t iov_cnt, uint32_t *crc_dst,

			       uint32_t seed, int flags, spdk_accel_completion_cb cb_fn, void *cb_arg)

			       uint32_t seed, spdk_accel_completion_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);

	struct spdk_accel_task *accel_task;
@@ -674,14 +651,13 @@ spdk_accel_submit_copy_crc32cv(struct spdk_io_channel *ch, void *dst, 
	accel_task->op_code = SPDK_ACCEL_OPC_COPY_CRC32C;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}



int

spdk_accel_submit_compress(struct spdk_io_channel *ch, void *dst, uint64_t nbytes,

			   struct iovec *src_iovs, size_t src_iovcnt, uint32_t *output_size, int flags,

			   struct iovec *src_iovs, size_t src_iovcnt, uint32_t *output_size,

			   spdk_accel_completion_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
@@ -705,7 +681,6 @@ spdk_accel_submit_compress(struct spdk_io_channel *ch, void *dst, uint64_t nbyte 
	accel_task->op_code = SPDK_ACCEL_OPC_COMPRESS;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}
@@ -713,7 +688,7 @@ spdk_accel_submit_compress(struct spdk_io_channel *ch, void *dst, uint64_t nbyte 
int

spdk_accel_submit_decompress(struct spdk_io_channel *ch, struct iovec *dst_iovs,

			     size_t dst_iovcnt, struct iovec *src_iovs, size_t src_iovcnt,

			     uint32_t *output_size, int flags, spdk_accel_completion_cb cb_fn,

			     uint32_t *output_size, spdk_accel_completion_cb cb_fn,

			     void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
@@ -733,7 +708,6 @@ spdk_accel_submit_decompress(struct spdk_io_channel *ch, struct iovec *dst_iovs, 
	accel_task->op_code = SPDK_ACCEL_OPC_DECOMPRESS;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}
@@ -742,7 +716,7 @@ int 
spdk_accel_submit_encrypt(struct spdk_io_channel *ch, struct spdk_accel_crypto_key *key,

			  struct iovec *dst_iovs, uint32_t dst_iovcnt,

			  struct iovec *src_iovs, uint32_t src_iovcnt,

			  uint64_t iv, uint32_t block_size, int flags,

			  uint64_t iv, uint32_t block_size,

			  spdk_accel_completion_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
@@ -768,7 +742,6 @@ spdk_accel_submit_encrypt(struct spdk_io_channel *ch, struct spdk_accel_crypto_k 
	accel_task->op_code = SPDK_ACCEL_OPC_ENCRYPT;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}
@@ -777,7 +750,7 @@ int 
spdk_accel_submit_decrypt(struct spdk_io_channel *ch, struct spdk_accel_crypto_key *key,

			  struct iovec *dst_iovs, uint32_t dst_iovcnt,

			  struct iovec *src_iovs, uint32_t src_iovcnt,

			  uint64_t iv, uint32_t block_size, int flags,

			  uint64_t iv, uint32_t block_size,

			  spdk_accel_completion_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
@@ -803,7 +776,6 @@ spdk_accel_submit_decrypt(struct spdk_io_channel *ch, struct spdk_accel_crypto_k 
	accel_task->op_code = SPDK_ACCEL_OPC_DECRYPT;

	accel_task->src_domain = NULL;

	accel_task->dst_domain = NULL;

	ACCEL_ASSIGN_FLAGS(accel_task, flags);



	return accel_submit_task(accel_ch, accel_task);

}
@@ -1015,7 +987,7 @@ spdk_accel_append_copy(struct spdk_accel_sequence **pseq, struct spdk_io_channel 
		       struct spdk_memory_domain *dst_domain, void *dst_domain_ctx,

		       struct iovec *src_iovs, uint32_t src_iovcnt,

		       struct spdk_memory_domain *src_domain, void *src_domain_ctx,

		       int flags, spdk_accel_step_cb cb_fn, void *cb_arg)

		       spdk_accel_step_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);

	struct spdk_accel_task *task;
@@ -1048,7 +1020,6 @@ spdk_accel_append_copy(struct spdk_accel_sequence **pseq, struct spdk_io_channel 
	task->s.iovcnt = src_iovcnt;

	task->nbytes = accel_get_iovlen(src_iovs, src_iovcnt);

	task->op_code = SPDK_ACCEL_OPC_COPY;

	ACCEL_ASSIGN_FLAGS(task, flags);



	TAILQ_INSERT_TAIL(&seq->tasks, task, seq_link);

	*pseq = seq;
@@ -1060,7 +1031,7 @@ int 
spdk_accel_append_fill(struct spdk_accel_sequence **pseq, struct spdk_io_channel *ch,

		       void *buf, uint64_t len,

		       struct spdk_memory_domain *domain, void *domain_ctx, uint8_t pattern,

		       int flags, spdk_accel_step_cb cb_fn, void *cb_arg)

		       spdk_accel_step_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);

	struct spdk_accel_task *task;
@@ -1108,7 +1079,6 @@ spdk_accel_append_fill(struct spdk_accel_sequence **pseq, struct spdk_io_channel 
	task->dst_domain = domain;

	task->dst_domain_ctx = domain_ctx;

	task->op_code = SPDK_ACCEL_OPC_FILL;

	ACCEL_ASSIGN_FLAGS(task, flags);



	TAILQ_INSERT_TAIL(&seq->tasks, task, seq_link);

	*pseq = seq;
@@ -1122,7 +1092,7 @@ spdk_accel_append_decompress(struct spdk_accel_sequence **pseq, struct spdk_io_c 
			     struct spdk_memory_domain *dst_domain, void *dst_domain_ctx,

			     struct iovec *src_iovs, size_t src_iovcnt,

			     struct spdk_memory_domain *src_domain, void *src_domain_ctx,

			     int flags, spdk_accel_step_cb cb_fn, void *cb_arg)

			     spdk_accel_step_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);

	struct spdk_accel_task *task;
@@ -1157,7 +1127,6 @@ spdk_accel_append_decompress(struct spdk_accel_sequence **pseq, struct spdk_io_c 
	task->s.iovcnt = src_iovcnt;

	task->nbytes = accel_get_iovlen(src_iovs, src_iovcnt);

	task->op_code = SPDK_ACCEL_OPC_DECOMPRESS;

	ACCEL_ASSIGN_FLAGS(task, flags);



	TAILQ_INSERT_TAIL(&seq->tasks, task, seq_link);

	*pseq = seq;
@@ -1172,7 +1141,7 @@ spdk_accel_append_encrypt(struct spdk_accel_sequence **pseq, struct spdk_io_chan 
			  struct spdk_memory_domain *dst_domain, void *dst_domain_ctx,

			  struct iovec *src_iovs, uint32_t src_iovcnt,

			  struct spdk_memory_domain *src_domain, void *src_domain_ctx,

			  uint64_t iv, uint32_t block_size, int flags,

			  uint64_t iv, uint32_t block_size,

			  spdk_accel_step_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
@@ -1211,7 +1180,6 @@ spdk_accel_append_encrypt(struct spdk_accel_sequence **pseq, struct spdk_io_chan 
	task->iv = iv;

	task->block_size = block_size;

	task->op_code = SPDK_ACCEL_OPC_ENCRYPT;

	ACCEL_ASSIGN_FLAGS(task, flags);



	TAILQ_INSERT_TAIL(&seq->tasks, task, seq_link);

	*pseq = seq;
@@ -1226,7 +1194,7 @@ spdk_accel_append_decrypt(struct spdk_accel_sequence **pseq, struct spdk_io_chan 
			  struct spdk_memory_domain *dst_domain, void *dst_domain_ctx,

			  struct iovec *src_iovs, uint32_t src_iovcnt,

			  struct spdk_memory_domain *src_domain, void *src_domain_ctx,

			  uint64_t iv, uint32_t block_size, int flags,

			  uint64_t iv, uint32_t block_size,

			  spdk_accel_step_cb cb_fn, void *cb_arg)

{

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);
@@ -1265,7 +1233,6 @@ spdk_accel_append_decrypt(struct spdk_accel_sequence **pseq, struct spdk_io_chan 
	task->iv = iv;

	task->block_size = block_size;

	task->op_code = SPDK_ACCEL_OPC_DECRYPT;

	ACCEL_ASSIGN_FLAGS(task, flags);



	TAILQ_INSERT_TAIL(&seq->tasks, task, seq_link);

	*pseq = seq;