Commit 6fa0d298 authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Tomasz Zawadzki
Browse files

lib/event: apply allowlist to all RPC servers 



RPC allowlist is one of application-wide components - it is not
differentiated between RPC servers. To clarify our intentions, move
spdk_rpc_set_allowlist() call in bootstrap_fn() before any RPC server
is initialized. This changes the behavior of `--rpcs-allowed`, because
allowlist will now apply to RPCs read from JSON configuration file
as well as RPCs incoming during application runtime.

Change-Id: I83e62b7c432293fa43fab4201adb7064277d5d18
Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21654


Reviewed-by: default avatarJohn Levon <levon@movementarian.org>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
parent d40c5443

lib/event/app.c

+2 −4
Original line number Diff line number Diff line
@@ -308,8 +308,6 @@ app_start_rpc(int rc, void *arg1) 
		return;

	}



	spdk_rpc_set_allowlist(g_spdk_app.rpc_allowlist);



	opts.size = SPDK_SIZEOF(&opts, log_level);

	opts.log_file = g_spdk_app.rpc_log_file;

	opts.log_level = g_spdk_app.rpc_log_level;
@@ -505,6 +503,8 @@ bootstrap_fn(void *arg1) 
	struct spdk_rpc_opts opts;

	int rc;



	spdk_rpc_set_allowlist(g_spdk_app.rpc_allowlist);



	if (g_spdk_app.json_config_file) {

		g_delay_subsystem_init = false;

		spdk_subsystem_init_from_json_config(g_spdk_app.json_config_file, g_spdk_app.rpc_addr,
@@ -514,8 +514,6 @@ bootstrap_fn(void *arg1) 
		if (!g_delay_subsystem_init) {

			spdk_subsystem_init(app_start_rpc, NULL);

		} else {

			spdk_rpc_set_allowlist(g_spdk_app.rpc_allowlist);



			opts.size = SPDK_SIZEOF(&opts, log_level);

			opts.log_file = g_spdk_app.rpc_log_file;

			opts.log_level = g_spdk_app.rpc_log_level;