Commit d40c5443 authored by Krzysztof Karas's avatar Krzysztof Karas Committed by Tomasz Zawadzki
Browse files

lib/init: deprecate spdk_subsystem_init_from_json_config 



Change-Id: If03fe50ad45a923c129e8113c753fbe5b3a4db82
Signed-off-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21322


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 9a86498d

CHANGELOG.md

+5 −0
Original line number Diff line number Diff line
@@ -2,6 +2,11 @@ 


## v24.05: (Upcoming Release)



### init



Function `spdk_subsystem_init_from_json_config` is deprecated and will be removed in 24.09 release.

Please use `spdk_subsystem_load_config` instead.



## v24.01



### accel

deprecation.md

+7 −0
Original line number Diff line number Diff line
@@ -33,6 +33,13 @@ in 24.05 release. 
The function is deprecated and will be removed in 24.05 release. Please use `SPDK_IOV_ONE`

macro instead.



### init



#### `spdk_subsystem_init_from_json_config`



The function is deprecated and will be removed in 24.09 release. Please use

`spdk_subsystem_load_config` instead.



### nvmf



#### `spdk_nvmf_qpair_disconnect`

include/spdk/init.h

+3 −0
Original line number Diff line number Diff line
@@ -85,6 +85,9 @@ void spdk_subsystem_init(spdk_subsystem_init_fn cb_fn, void *cb_arg); 
 * Like spdk_subsystem_init, but additionally configure each subsystem using the provided JSON config

 * file. This will automatically start a JSON RPC server and then stop it.

 *

 * Deprecated - will be removed in 24.09 SPDK release. Please use

 * \ref spdk_subsystem_load_config.

 *

 * \param json_config_file Path to a JSON config file.

 * \param rpc_addr Path to a unix domain socket to send configuration RPCs to.

 * \param cb_fn Function called when the process is complete.

lib/init/json_config.c

+5 −0
Original line number Diff line number Diff line
@@ -635,6 +635,9 @@ fail: 
	app_json_config_load_done(ctx, -EINVAL);

}



SPDK_LOG_DEPRECATION_REGISTER(spdk_subsystem_init_from_json_config,

			      "spdk_subsystem_init_from_json_config is deprecated", "v24.09", 0);



void

spdk_subsystem_init_from_json_config(const char *json_config_file, const char *rpc_addr,

				     spdk_subsystem_init_fn cb_fn, void *cb_arg,
@@ -643,6 +646,8 @@ spdk_subsystem_init_from_json_config(const char *json_config_file, const char *r 
	char *json = NULL;

	ssize_t json_size = 0;



	SPDK_LOG_DEPRECATED(spdk_subsystem_init_from_json_config);



	assert(cb_fn);



	json = read_file(json_config_file, &json_size);