Commit 55aa2f66 authored by Konrad Sztyber's avatar Konrad Sztyber
Browse files

nvme: drop support for submit_accel_crc32 



It was deprecated, and the TCP transport no longer uses it for data
digest calculations.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ic9d5be8972b73325a35bcaff7ed4998fd34f7b8b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25160


Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeliu@tencent.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
parent 0439dfaf

deprecation.md

+0 −7
Original line number Diff line number Diff line
@@ -19,13 +19,6 @@ The tags can be matched with the level 4 headers below. 


## Deprecation Notices



### nvme



#### `spdk_nvme_accel_fn_table.submit_accel_crc32c`



This callback is now deprecated and will be removed in the v25.01 release.  Please use the append

API (`append_crc32c`, `finish_sequence`, `reverse_sequence`, `abort_sequence`) instead.



### gpt



#### `old_gpt_guid`

include/spdk/nvme.h

+2 −3
Original line number Diff line number Diff line
@@ -341,9 +341,8 @@ struct spdk_nvme_accel_fn_table { 
	 */

	size_t table_size;



	/** The accelerated crc32c function. */

	void (*submit_accel_crc32c)(void *ctx, uint32_t *dst, struct iovec *iov,

				    uint32_t iov_cnt, uint32_t seed, spdk_nvme_accel_completion_cb cb_fn, void *cb_arg);

	/* Hole at bytes 8-15. */

	uint8_t reserved8[8];



	/** Finish an accel sequence */

	void (*finish_sequence)(void *seq, spdk_nvme_accel_completion_cb cb_fn, void *cb_arg);

lib/nvme/nvme_poll_group.c

+0 −8
Original line number Diff line number Diff line
@@ -7,9 +7,6 @@ 


#include "nvme_internal.h"



SPDK_LOG_DEPRECATION_REGISTER(nvme_accel_fn_submit_crc,

			      "spdk_nvme_accel_fn_table.submit_accel_crc32c", "v25.01", 0);



struct spdk_nvme_poll_group *

spdk_nvme_poll_group_create(void *ctx, struct spdk_nvme_accel_fn_table *table)

{
@@ -28,7 +25,6 @@ spdk_nvme_poll_group_create(void *ctx, struct spdk_nvme_accel_fn_table *table) 
		group->accel_fn_table.field = table->field; \

	} \



		SET_FIELD(submit_accel_crc32c);

		SET_FIELD(append_crc32c);

		SET_FIELD(append_copy);

		SET_FIELD(finish_sequence);
@@ -61,10 +57,6 @@ spdk_nvme_poll_group_create(void *ctx, struct spdk_nvme_accel_fn_table *table) 
		return NULL;

	}



	if (group->accel_fn_table.submit_accel_crc32c != NULL) {

		SPDK_LOG_DEPRECATED(nvme_accel_fn_submit_crc);

	}



	group->ctx = ctx;

	STAILQ_INIT(&group->tgroups);

test/make/check_so_deps.sh

+6 −0
Original line number Diff line number Diff line
@@ -161,6 +161,12 @@ function confirm_abi_deps() { 
			soname_regexp = ^libspdk_nvme\\.so\\.13\\.*$

			has_data_member_regexp = ^psk$

			has_data_member_inserted_between = {4936, 6536}

		[suppress_type]

			label = Removed spdk_nvme_accel_fn_table.submit_accel_crc32c field

			name = spdk_nvme_accel_fn_table

			soname_regexp = ^libspdk_nvme\\.so\\.14\\.*$

			has_data_member_regexp = ^submit_accel_crc32c$

			has_data_member_inserted_between = {64, 128}

	EOF



	for object in "$libdir"/libspdk_*.so; do