Commit 0439dfaf authored by Konrad Sztyber's avatar Konrad Sztyber
Browse files

nvme/tcp: reverse checks for append_crc support 



It reduces one level of indentation.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2782978e7d132eafa230319a885a77f023f54004
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25159


Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: default avatarChangpeng Liu <changpeliu@tencent.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent bf63daa5

lib/nvme/nvme_tcp.c

+33 −35
Original line number Diff line number Diff line
@@ -583,11 +583,11 @@ pdu_accel_compute_crc32(struct nvme_tcp_pdu *pdu) 
		return false;

	}



	if (tqpair->qpair.poll_group == NULL) {

	if (tqpair->qpair.poll_group == NULL ||

	    tgroup->group.group->accel_fn_table.append_crc32c == NULL) {

		return false;

	}



	if (tgroup->group.group->accel_fn_table.append_crc32c != NULL) {

	rc = nvme_tcp_accel_append_crc32c(tgroup, &req->accel_sequence,

					  &pdu->data_digest_crc32,

					  pdu->data_iov, pdu->data_iovcnt, 0,
@@ -608,9 +608,6 @@ pdu_accel_compute_crc32(struct nvme_tcp_pdu *pdu) 
	return true;

}



	return false;

}



static void

pdu_compute_crc32_seq_cb(void *cb_arg, int status)

{
@@ -1386,7 +1383,10 @@ nvme_tcp_accel_recv_compute_crc32(struct nvme_tcp_req *treq, struct nvme_tcp_pdu 
		return false;

	}



	if (tgroup->group.group->accel_fn_table.append_crc32c != NULL) {

	if (tgroup->group.group->accel_fn_table.append_crc32c == NULL) {

		return false;

	}



	nvme_tcp_req_copy_pdu(treq, pdu);

	rc = nvme_tcp_accel_append_crc32c(tgroup, &req->accel_sequence,

					  &treq->pdu->data_digest_crc32,
@@ -1404,10 +1404,8 @@ nvme_tcp_accel_recv_compute_crc32(struct nvme_tcp_req *treq, struct nvme_tcp_pdu 


	nvme_tcp_qpair_set_recv_state(tqpair, NVME_TCP_PDU_RECV_STATE_AWAIT_PDU_READY);

	nvme_tcp_c2h_data_payload_handle(tqpair, treq->pdu, &dummy);

		return true;

	}



	return false;

	return true;

}



static void