Commit beb468e9 authored Jul 22, 2020 by Jacek Kalwas Committed by Jim Harris Aug 04, 2020

nvmf: fix cc.en and csts.rdy setting during shutdown



CC.EN, CSTS.RDY should not be modified during shutdown.
It doesn't make much sense (against nvme spec) and nvmf spec 1.1
doesn't mentioned it (4.6) either.

Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Change-Id: I7014b10b0217db61c3d380d5c0843808e54577cd
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3477


Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Seth Howell <seth.howell@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>

parent aedcec8a

lib/nvmf/ctrlr.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -811,8 +811,6 @@ nvmf_prop_set_cc(struct spdk_nvmf_ctrlr *ctrlr, uint32_t value)
		SPDK_DEBUGLOG(SPDK_LOG_NVMF, "Property Set CC Shutdown %u%ub!\n",
		cc.bits.shn >> 1, cc.bits.shn & 1);
		ctrlr->vcprop.cc.bits.shn = cc.bits.shn;
		ctrlr->vcprop.cc.bits.en = 0;
		ctrlr->vcprop.csts.bits.rdy = 0;
		spdk_for_each_channel(ctrlr->subsys->tgt,
		nvmf_ctrlr_disconnect_io_qpairs_on_pg,
		ctrlr,