Commit 2da86de6 authored Feb 21, 2019 by Ziye Yang Committed by Jim Harris Feb 21, 2019

nvmf/tcp: fix error message printing in spdk_nvmf_tcp_qpair_set_recv_state



If the current recv_state of qpair is same with the state to be set,
we will print error message. And checked the current code,
we should add a check to avoid this.

Change-Id: I49334f637c48e565e785d1fe6d0f000e18b2048a
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.gerrithub.io/c/445653


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

parent 7cd3a6f5

lib/nvmf/tcp.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1921,8 +1921,10 @@ spdk_nvmf_tcp_sock_process(struct spdk_nvmf_tcp_qpair *tqpair)
		return NVME_TCP_PDU_FATAL;
		} else if (rc > 0) {
		pdu->ch_valid_bytes += rc;
		if (spdk_likely(tqpair->recv_state == NVME_TCP_PDU_RECV_STATE_AWAIT_PDU_READY)) {
		spdk_nvmf_tcp_qpair_set_recv_state(tqpair, NVME_TCP_PDU_RECV_STATE_AWAIT_PDU_CH);
		}
		}

		if (pdu->ch_valid_bytes < sizeof(struct spdk_nvme_tcp_common_pdu_hdr)) {
		return NVME_TCP_PDU_IN_PROGRESS;