Commit 28021d2a authored by Maciej Wawryk's avatar Maciej Wawryk Committed by Jim Harris
Browse files

test: Shellcheck - ignore SC2001 warnings 



Add to permanently excluded in shellcheck:
	^SC2001: See if you can use ${variable//search/replace} instead.
In some cases we need more complex sed substitution than only replacing string.
For example: test_stack=$(echo "$test_stack" | sed -e 's@;[^;]*$@@')

Signed-off-by: default avatarMaciej Wawryk <maciejx.wawryk@intel.com>
Change-Id: I3e997af5232d8b15518fd54528b2e51e75a19d8c
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470903


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent a3c90994

scripts/check_format.sh

+3 −2
Original line number Diff line number Diff line
@@ -241,7 +241,7 @@ if hash shellcheck 2>/dev/null; then 
	# Error descriptions can also be found at: https://github.com/koalaman/shellcheck/wiki

	# This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors.

	SHCK_EXCLUDE="SC1001,SC1003,\

SC1083,SC1113,SC2001,SC2002,SC2004,\

SC1083,SC1113,SC2002,SC2004,\

SC2010,SC2012,SC2013,SC2016,\

SC2034,SC2045,SC2046,\

SC2068,SC2086,SC2089,SC2090,\
@@ -257,11 +257,12 @@ SC2230" 
	# We are aware about below exclude list and we want this errors to be excluded.

	# SC1090: Can't follow non-constant source. Use a directive to specify location.

	# SC1091: Not following: (error message here)

        # SC2001: See if you can use ${variable//search/replace} instead.

	# SC2206: Quote to prevent word splitting/globbing,

	#         or split robustly with mapfile or read -a.

	# SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).

	# SC2223: This default assignment may cause DoS due to globbing. Quote it.

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091,SC2206,SC2207,SC2223"

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091,SC2001,SC2206,SC2207,SC2223"



	SHCK_FORMAT="diff"

	SHCK_APPLY=true