Commit a3c90994 authored by Maciej Wawryk's avatar Maciej Wawryk Committed by Jim Harris
Browse files

test: Shellcheck - correct rule: expr is antiquated 



Correct shellcheck rule SC2003: expr is antiquated.
Consider rewriting this using $((..)), ${} or .

Signed-off-by: default avatarMaciej Wawryk <maciejx.wawryk@intel.com>
Change-Id: I98a677cce7a1ffdfa5e1cf417a128900fba64124
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470902


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 4b3a6e87

scripts/check_format.sh

+1 −1
Original line number Diff line number Diff line
@@ -241,7 +241,7 @@ if hash shellcheck 2>/dev/null; then 
	# Error descriptions can also be found at: https://github.com/koalaman/shellcheck/wiki

	# This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors.

	SHCK_EXCLUDE="SC1001,SC1003,\

SC1083,SC1113,SC2001,SC2002,SC2003,SC2004,\

SC1083,SC1113,SC2001,SC2002,SC2004,\

SC2010,SC2012,SC2013,SC2016,\

SC2034,SC2045,SC2046,\

SC2068,SC2086,SC2089,SC2090,\

scripts/prep_benchmarks.sh

+2 −2
Original line number Diff line number Diff line
@@ -18,10 +18,10 @@ function configure_performance() { 
	echo "Done"



	echo -n "Moving all interrupts off of core 0..."

	count=$(expr $(nproc) / 4)

	count=$(($(nproc) / 4))

	cpumask="e"

	for ((i=1; i<$count; i++)); do

		if [ $(expr $i % 8) -eq 0 ]; then

		if [ $((i % 8)) -eq 0 ]; then

			cpumask=",$cpumask"

		fi

		cpumask="f$cpumask"