Commit 21fa6a73 authored by Cody Cheng's avatar Cody Cheng Committed by Tomasz Zawadzki
Browse files

nvmf: fix unterminated-string-initialization warning 



Adds nonstring attribute to fixed-size char arrays to fix GCC 15 error
about missing null terminator when initializing with string literals.

Fixes #3661

Change-Id: Iddc6ec5a97e934d9bac7435b94c61497414c0b28
Signed-off-by: default avatarCody Cheng <cody.cheng@unh.edu>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25949


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarChangpeng Liu <changpeliu@tencent.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
parent 1965c4dd

lib/nvmf/nvmf_rpc.c

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ static int rpc_ana_state_parse(const char *str, enum spdk_nvme_ana_state *ana_st 
static int

json_write_hex_str(struct spdk_json_write_ctx *w, const void *data, size_t size)

{

	static const char hex_char[16] = "0123456789ABCDEF";

	static const char __attribute__((nonstring)) hex_char[16] = "0123456789ABCDEF";

	const uint8_t *buf = data;

	char *str, *out;

	int rc;

test/unit/lib/nvmf/ctrlr_bdev.c/ctrlr_bdev_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -554,7 +554,7 @@ test_nvmf_bdev_ctrlr_identify_ns(void) 
	struct spdk_bdev bdev = {};

	struct spdk_bdev_desc desc = {};

	uint8_t ns_g_id[16] = "abcdefgh";

	uint8_t eui64[8] = "12345678";

	uint8_t __attribute__((nonstring)) eui64[8] = "12345678";



	desc.bdev = &bdev;

	ns.desc = &desc;