Commit 1965c4dd authored by Nitheesh Prakash's avatar Nitheesh Prakash Committed by Tomasz Zawadzki
Browse files

nvmf: add qpair->ctrlr pointer check to rpc_nvmf_get_qpairs() 



Fixes issue #3391

There was an issue where qpair->ctrlr was NULL
which led to a segmentation violation and crash of SPDK.
Here, Added additional check for NULL pointer in
 qpair->ctrlr on rpc_nvmf_get_qpairs()

Change-Id: I5d28574aea35c3b0427eee81fc2f1991f80512a9
Signed-off-by: default avatarNitheesh Prakash <nith16eesh@gmail.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/25662


Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent 41700d76

lib/nvmf/nvmf_rpc.c

+1 −1
Original line number Diff line number Diff line
@@ -3024,7 +3024,7 @@ rpc_nvmf_get_qpairs(struct spdk_io_channel_iter *i) 
	group = spdk_io_channel_get_ctx(ch);



	TAILQ_FOREACH(qpair, &group->qpairs, link) {

		if (qpair->ctrlr->subsys == ctx->subsystem) {

		if (qpair->ctrlr && qpair->ctrlr->subsys == ctx->subsystem) {

			dump_nvmf_qpair(ctx->w, qpair);

		}

	}