Commit 169bab1f authored by Jaroslaw Chachulski's avatar Jaroslaw Chachulski Committed by Tomasz Zawadzki
Browse files

scripts/rpc: remove default value from iscsi functions 



Removing default options from parser command to prevent overwrite by
argparse the defaults defined in the .c files.

Signed-off-by: default avatarJaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: I11ef4947324dfba796fc16da566c0b8a1e606a00
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12922


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 9518bbc2

scripts/rpc.py

+3 −3
Original line number Diff line number Diff line
@@ -1345,7 +1345,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
    *** The Portal/Initiator Groups must be precreated ***""")

    p.add_argument('queue_depth', help='Desired target queue depth', type=int)

    p.add_argument('-g', '--chap-group', help="""Authentication group ID for this target node.

    *** Authentication group must be precreated ***""", type=int, default=0)

    *** Authentication group must be precreated ***""", type=int)

    p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this target node.

    *** Mutually exclusive with --require-chap ***""", action='store_true')

    p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this target node.
@@ -1387,7 +1387,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
                              help='Set CHAP authentication for the target node')

    p.add_argument('name', help='Target node name (ASCII)')

    p.add_argument('-g', '--chap-group', help="""Authentication group ID for this target node.

    *** Authentication group must be precreated ***""", type=int, default=0)

    *** Authentication group must be precreated ***""", type=int)

    p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this target node.

    *** Mutually exclusive with --require-chap ***""", action='store_true')

    p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this target node.
@@ -1628,7 +1628,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
                              help='Set CHAP authentication for discovery sessions specific for the portal group')

    p.add_argument('tag', help='Portal group tag (unique, integer > 0)', type=int)

    p.add_argument('-g', '--chap-group', help="""Authentication group ID for this portal group.

    *** Authentication group must be precreated ***""", type=int, default=0)

    *** Authentication group must be precreated ***""", type=int)

    p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this portal group.

    *** Mutually exclusive with --require-chap ***""", action='store_true')

    p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this portal group.