Commit 9518bbc2 authored by Jaroslaw Chachulski's avatar Jaroslaw Chachulski Committed by Tomasz Zawadzki
Browse files

scripts/rpc: remove default value from nvmf_create_subsystem function 



Removing default options from parser command to prevent overwrite by
argparse the defaults defined in the .c files.

Signed-off-by: default avatarJaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: I3e009139e10bbd2c9aa94e88ffdeb3a6570c4110
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12911


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
parent 16772e6d

scripts/rpc.py

+5 −5
Original line number Diff line number Diff line
@@ -2164,16 +2164,16 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
    p.add_argument('-t', '--tgt-name', help='The name of the parent NVMe-oF target (optional)', type=str)

    p.add_argument("-s", "--serial-number", help="""

    Format:  'sn' etc

    Example: 'SPDK00000000000001'""", default='00000000000000000000')

    Example: 'SPDK00000000000001'""")

    p.add_argument("-d", "--model-number", help="""

    Format:  'mn' etc

    Example: 'SPDK Controller'""", default='SPDK bdev Controller')

    Example: 'SPDK Controller'""")

    p.add_argument("-a", "--allow-any-host", action='store_true', help="Allow any host to connect (don't enforce allowed host NQN list)")

    p.add_argument("-m", "--max-namespaces", help="Maximum number of namespaces allowed",

                   type=int, default=0)

                   type=int)

    p.add_argument("-r", "--ana-reporting", action='store_true', help="Enable ANA reporting feature")

    p.add_argument("-i", "--min_cntlid", help="Minimum controller ID", type=int, default=1)

    p.add_argument("-I", "--max_cntlid", help="Maximum controller ID", type=int, default=0xffef)

    p.add_argument("-i", "--min_cntlid", help="Minimum controller ID", type=int)

    p.add_argument("-I", "--max_cntlid", help="Maximum controller ID", type=int)

    p.set_defaults(func=nvmf_create_subsystem)



    def nvmf_delete_subsystem(args):