Commit 14636419 authored May 02, 2024 by Jim Harris Committed by Tomasz Zawadzki May 09, 2024

nvmf: always use 3 digits for nvmf_tgt_poll_group thread name



This helps with consistency on the names, including sorting.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8ea48b2620f67fabfa9bb482d6b1947440145517
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23017


Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

parent 1f4a57b4

doc/jsonrpc.md

+2 −2

Original line number	Diff line number	Diff line
		@@ -4884,7 +4884,7 @@ Example response:
		"result": {
		"poll_groups": [
		{
		"thread": "nvmf_tgt_poll_group_0",
		"thread": "nvmf_tgt_poll_group_000",
		"transports": [
		{
		"trname": "RDMA",
		@@ -4926,7 +4926,7 @@ Example response:
		]
		},
		{
		"thread": "nvmf_tgt_poll_group_1",
		"thread": "nvmf_tgt_poll_group_001",
		"transports": [
		{
		"trname": "RDMA",

examples/nvmf/nvmf/nvmf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -617,7 +617,7 @@ nvmf_poll_groups_create(void)
		SPDK_ENV_FOREACH_CORE(i) {
		spdk_cpuset_zero(&tmp_cpumask);
		spdk_cpuset_set_cpu(&tmp_cpumask, i, true);
		snprintf(thread_name, sizeof(thread_name), "nvmf_tgt_poll_group_%u", i);
		snprintf(thread_name, sizeof(thread_name), "nvmf_tgt_poll_group_%03u", i);

		thread = spdk_thread_create(thread_name, &tmp_cpumask);
		assert(thread != NULL);

module/event/subsystems/nvmf/nvmf_tgt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -193,7 +193,7 @@ nvmf_tgt_create_poll_groups(void)
		if (g_poll_groups_mask && !spdk_cpuset_get_cpu(g_poll_groups_mask, cpu)) {
		continue;
		}
		snprintf(thread_name, sizeof(thread_name), "nvmf_tgt_poll_group_%u", count++);
		snprintf(thread_name, sizeof(thread_name), "nvmf_tgt_poll_group_%03u", count++);

		thread = spdk_thread_create(thread_name, g_poll_groups_mask);
		assert(thread != NULL);