Commit 1f4a57b4 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Tomasz Zawadzki
Browse files

thread: use spdk_trace_register_description_ext() to register traces 



Tracepoint arguments are 8B by default and
spdk_trace_register_description_ext() makes it possible to change that.
spdk_io_channel->ref is only 4B, so we'd record 4B of garbage (probably
destroy_ref, since it's directly after ref).

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I01234ec4705f8919722cc176f06d6ace178c9cb2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23002


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
parent f906b912

lib/thread/thread.c

+14 −8
Original line number Diff line number Diff line
@@ -288,14 +288,20 @@ static __thread struct spdk_thread *tls_thread = NULL; 


SPDK_TRACE_REGISTER_FN(thread_trace, "thread", TRACE_GROUP_THREAD)

{

	spdk_trace_register_description("THREAD_IOCH_GET",

					TRACE_THREAD_IOCH_GET,

	struct spdk_trace_tpoint_opts opts[] = {

		{

			"THREAD_IOCH_GET", TRACE_THREAD_IOCH_GET,

			OWNER_TYPE_NONE, OBJECT_NONE, 0,

					SPDK_TRACE_ARG_TYPE_INT, "refcnt");

	spdk_trace_register_description("THREAD_IOCH_PUT",

					TRACE_THREAD_IOCH_PUT,

			{{ "refcnt", SPDK_TRACE_ARG_TYPE_INT, 4 }}

		},

		{

			"THREAD_IOCH_PUT", TRACE_THREAD_IOCH_PUT,

			OWNER_TYPE_NONE, OBJECT_NONE, 0,

					SPDK_TRACE_ARG_TYPE_INT, "refcnt");

			{{ "refcnt", SPDK_TRACE_ARG_TYPE_INT, 4 }}

		}

	};



	spdk_trace_register_description_ext(opts, SPDK_COUNTOF(opts));

}



/*