Commit 0aca4d91 authored by paul luse's avatar paul luse Committed by Tomasz Zawadzki
Browse files

lib/idxd: clean up some casting and type issues 



Signed-off-by: default avatarpaul luse <paul.e.luse@intel.com>
Change-Id: If196c51deead9828fd75388f34b5622884c5e2d8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2204


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Mellanox Build Bot
parent d7b0a892

lib/idxd/idxd.c

+7 −7
Original line number Diff line number Diff line
@@ -659,7 +659,7 @@ _idxd_prep_command(struct spdk_idxd_io_channel *chan, 


	desc->flags = IDXD_FLAG_COMPLETION_ADDR_VALID | IDXD_FLAG_REQUEST_COMPLETION;

	desc->completion_addr = (uintptr_t)&comp->hw;

	comp->cb_arg = (uint64_t)cb_arg;

	comp->cb_arg = cb_arg;

	comp->cb_fn = cb_fn;



	return desc;
@@ -685,7 +685,7 @@ spdk_idxd_submit_copy(struct spdk_idxd_io_channel *chan, void *dst, const void * 
	desc->xfer_size = nbytes;



	/* Submit operation. */

	movdir64b((uint64_t *)chan->ring_ctrl.portal, desc);

	movdir64b(chan->ring_ctrl.portal, desc);



	return 0;

}
@@ -716,7 +716,7 @@ spdk_idxd_submit_dualcast(struct spdk_idxd_io_channel *chan, void *dst1, void *d 
	desc->xfer_size = nbytes;



	/* Submit operation. */

	movdir64b((uint64_t *)chan->ring_ctrl.portal, desc);

	movdir64b(chan->ring_ctrl.portal, desc);



	return 0;

}
@@ -741,7 +741,7 @@ spdk_idxd_submit_compare(struct spdk_idxd_io_channel *chan, void *src1, const vo 
	desc->xfer_size = nbytes;



	/* Submit operation. */

	movdir64b((uint64_t *)chan->ring_ctrl.portal, desc);

	movdir64b(chan->ring_ctrl.portal, desc);



	return 0;

}
@@ -766,7 +766,7 @@ spdk_idxd_submit_fill(struct spdk_idxd_io_channel *chan, void *dst, uint64_t fil 
	desc->xfer_size = nbytes;



	/* Submit operation. */

	movdir64b((uint64_t *)chan->ring_ctrl.portal, desc);

	movdir64b(chan->ring_ctrl.portal, desc);



	return 0;

}
@@ -793,7 +793,7 @@ spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *dst, void * 
	desc->xfer_size = nbytes;



	/* Submit operation. */

	movdir64b((uint64_t *)chan->ring_ctrl.portal, desc);

	movdir64b(chan->ring_ctrl.portal, desc);



	return 0;

}
@@ -854,7 +854,7 @@ spdk_idxd_process_events(struct spdk_idxd_io_channel *chan) 
					break;

				}



				comp->cb_fn((void *)comp->cb_arg, status);

				comp->cb_fn(comp->cb_arg, status);

				comp->hw.status = status = 0;

				spdk_bit_array_clear(chan->ring_ctrl.ring_slots, index);

			}

lib/idxd/idxd.h

+1 −1
Original line number Diff line number Diff line
@@ -128,7 +128,7 @@ struct idxd_group { 
 */

struct idxd_comp {

	struct idxd_hw_comp_record	hw;

	uint64_t			cb_arg;

	void				*cb_arg;

	spdk_idxd_req_cb		cb_fn;

	uint64_t			pad1;

	uint64_t			pad2;