Commit d7b0a892 authored by paul luse's avatar paul luse Committed by Tomasz Zawadzki
Browse files

lib/accel: minor cleanup: remove extra stack variable in functions 



Signed-off-by: default avatarpaul luse <paul.e.luse@intel.com>
Change-Id: I8d2b286f5e21e0de32f67b3449e3fcf3904a2a9b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2401


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Mellanox Build Bot
parent 89495464

lib/accel/accel_engine.c

+9 −14
Original line number Diff line number Diff line
@@ -115,11 +115,10 @@ int 
spdk_accel_submit_copy(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch,

		       void *dst, void *src, uint64_t nbytes, spdk_accel_completion_cb cb)

{

	struct spdk_accel_task *req = accel_req;

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);



	req->cb = cb;

	return accel_ch->engine->copy(req->offload_ctx, accel_ch->ch, dst, src, nbytes,

	accel_req->cb = cb;

	return accel_ch->engine->copy(accel_req->offload_ctx, accel_ch->ch, dst, src, nbytes,

				      _accel_engine_done);

}
@@ -129,7 +128,6 @@ spdk_accel_submit_dualcast(struct spdk_accel_task *accel_req, struct spdk_io_cha 
			   void *dst1, void *dst2, void *src, uint64_t nbytes,

			   spdk_accel_completion_cb cb)

{

	struct spdk_accel_task *req = accel_req;

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);



	if ((uintptr_t)dst1 & (ALIGN_4K - 1) || (uintptr_t)dst2 & (ALIGN_4K - 1)) {
@@ -137,8 +135,8 @@ spdk_accel_submit_dualcast(struct spdk_accel_task *accel_req, struct spdk_io_cha 
		return -EINVAL;

	}



	req->cb = cb;

	return accel_ch->engine->dualcast(req->offload_ctx, accel_ch->ch, dst1, dst2, src, nbytes,

	accel_req->cb = cb;

	return accel_ch->engine->dualcast(accel_req->offload_ctx, accel_ch->ch, dst1, dst2, src, nbytes,

					  _accel_engine_done);

}
@@ -159,11 +157,10 @@ int 
spdk_accel_submit_fill(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch,

		       void *dst, uint8_t fill, uint64_t nbytes, spdk_accel_completion_cb cb)

{

	struct spdk_accel_task *req = accel_req;

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);



	req->cb = cb;

	return accel_ch->engine->fill(req->offload_ctx, accel_ch->ch, dst, fill, nbytes,

	accel_req->cb = cb;

	return accel_ch->engine->fill(accel_req->offload_ctx, accel_ch->ch, dst, fill, nbytes,

				      _accel_engine_done);

}
@@ -172,13 +169,11 @@ int 
spdk_accel_submit_crc32c(struct spdk_accel_task *accel_req, struct spdk_io_channel *ch,

			 uint32_t *dst, void *src, uint32_t seed, uint64_t nbytes, spdk_accel_completion_cb cb)

{

	struct spdk_accel_task *req = accel_req;

	struct accel_io_channel *accel_ch = spdk_io_channel_get_ctx(ch);



	req->cb = cb;

	return accel_ch->engine->crc32c(req->offload_ctx, accel_ch->ch, dst, src,

					seed, nbytes,

					_accel_engine_done);

	accel_req->cb = cb;

	return accel_ch->engine->crc32c(accel_req->offload_ctx, accel_ch->ch, dst, src,

					seed, nbytes, _accel_engine_done);

}