Commit 0219a750 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

bdev/nvme: add assertion to nvme_ctrlr_get_ref 



It is just a sanity check. A ref should not be acquired if the count has
already reached 0, as that means the controller was already scheduled
for unregistration.

It should not be hit by design, but should help #3736 triage.

Change-Id: I8f8537f5328c38103cd1447b75eaf86ab6a49f56
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26752


Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
parent a6e1d40c

module/bdev/nvme/bdev_nvme.c

+1 −0
Original line number Diff line number Diff line
@@ -875,6 +875,7 @@ static void 
nvme_ctrlr_get_ref(struct nvme_ctrlr *nvme_ctrlr)

{

	pthread_mutex_lock(&nvme_ctrlr->mutex);

	assert(nvme_ctrlr->ref > 0);

	nvme_ctrlr->ref++;

	pthread_mutex_unlock(&nvme_ctrlr->mutex);

}