Commit a6e1d40c authored by Artsiom Koltun's avatar Artsiom Koltun Committed by Tomasz Zawadzki
Browse files

posix: return bool false from is_ipv* functions 



Previously, these functions returned -1 on error, which is converted to
true when cast to bool in C. This is misleading, as false should be
returned on failure (with errno set).

Change-Id: Ie6f0a6b298c8d7e5e7c65e184c2ac89cf2550bef
Signed-off-by: default avatarArtsiom Koltun <artsiom.koltun@intel.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26875


Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-by: default avatarJim Harris <jim.harris@nvidia.com>
parent c35df47b

module/sock/posix/posix.c

+2 −2
Original line number Diff line number Diff line
@@ -1796,7 +1796,7 @@ posix_sock_is_ipv6(struct spdk_sock *_sock) 
	if (!sock->ready) {

		SPDK_ERRLOG("Connection %s.\n", sock->connect_ctx ? "in progress" : "failed");

		errno = sock->connect_ctx ? EAGAIN : ENOTCONN;

		return -1;

		return false;

	}



	memset(&sa, 0, sizeof sa);
@@ -1823,7 +1823,7 @@ posix_sock_is_ipv4(struct spdk_sock *_sock) 
	if (!sock->ready) {

		SPDK_ERRLOG("Connection %s.\n", sock->connect_ctx ? "in progress" : "failed");

		errno = sock->connect_ctx ? EAGAIN : ENOTCONN;

		return -1;

		return false;

	}



	memset(&sa, 0, sizeof sa);