Unverified Commit fb5e2354 authored by david-perez's avatar david-perez Committed by GitHub
Browse files

Register Gradle tasks instead of eagerly creating them (#1374)

Using `.register()` avoids creating possibly unnecessary tasks.
parent 003b1db6
Loading
Loading
Loading
Loading
+7 −7
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ fun generateSmithyBuild(services: AwsServices): String {
    """
}

task("generateSmithyBuild") {
tasks.register("generateSmithyBuild") {
    description = "generate smithy-build.json"
    inputs.property("servicelist", awsServices.services.toString())
    inputs.property("eventStreamAllowList", eventStreamAllowList)
@@ -138,7 +138,7 @@ task("generateSmithyBuild") {
    }
}

task("generateIndexMd") {
tasks.register("generateIndexMd") {
    inputs.property("servicelist", awsServices.services.toString())
    val indexMd = outputDir.resolve("index.md")
    outputs.file(indexMd)
@@ -147,7 +147,7 @@ task("generateIndexMd") {
    }
}

task("relocateServices") {
tasks.register("relocateServices") {
    description = "relocate AWS services to their final destination"
    doLast {
        awsServices.services.forEach {
@@ -172,7 +172,7 @@ task("relocateServices") {
    outputs.dir(sdkOutputDir)
}

task("relocateExamples") {
tasks.register("relocateExamples") {
    description = "relocate the examples folder & rewrite path dependencies"
    doLast {
        if (awsServices.examples.isNotEmpty()) {
@@ -193,7 +193,7 @@ task("relocateExamples") {
    outputs.dir(outputDir)
}

task<ExecRustBuildTool>("fixExampleManifests") {
tasks.register<ExecRustBuildTool>("fixExampleManifests") {
    description = "Adds dependency path and corrects version number of examples after relocation"
    enabled = awsServices.examples.isNotEmpty()

@@ -272,7 +272,7 @@ fun generateCargoWorkspace(services: AwsServices): String {
    """.trimMargin()
}

task("generateCargoWorkspace") {
tasks.register("generateCargoWorkspace") {
    description = "generate Cargo.toml workspace file"
    doFirst {
        outputDir.mkdirs()
@@ -346,7 +346,7 @@ tasks.register<ExecRustBuildTool>("generateVersionManifest") {
    )
}

task("finalizeSdk") {
tasks.register("finalizeSdk") {
    dependsOn("assemble")
    outputs.upToDateWhen { false }
    finalizedBy(
+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ tasks.register<JavaExec>("ktlintFormat") {
}

@Suppress("UnstableApiUsage")
task<JacocoMerge>("jacocoMerge") {
tasks.register<JacocoMerge>("jacocoMerge") {
    group = LifecycleBasePlugin.VERIFICATION_GROUP
    description = "Merge the JaCoCo data files from all subprojects into one"
    afterEvaluate {
+2 −2
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ val allCodegenTests = listOf(
    CodegenTest("com.aws.example#PokemonService", "pokemon_service_sdk")
)

task("generateSmithyBuild") {
tasks.register("generateSmithyBuild") {
    description = "generate smithy-build.json"
    doFirst {
        projectDir.resolve("smithy-build.json")
@@ -58,7 +58,7 @@ task("generateSmithyBuild") {
    }
}

task("generateCargoWorkspace") {
tasks.register("generateCargoWorkspace") {
    description = "generate Cargo.toml workspace file"
    doFirst {
        buildDir.resolve("$workingDirUnderBuildDir/Cargo.toml")
+2 −2
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ val allCodegenTests = listOf(
    CodegenTest("com.aws.example#PokemonService", "pokemon_service_client")
)

task("generateSmithyBuild") {
tasks.register("generateSmithyBuild") {
    description = "generate smithy-build.json"
    doFirst {
        projectDir.resolve("smithy-build.json")
@@ -102,7 +102,7 @@ task("generateSmithyBuild") {
    }
}

task("generateCargoWorkspace") {
tasks.register("generateCargoWorkspace") {
    description = "generate Cargo.toml workspace file"
    doFirst {
        buildDir.resolve("$workingDirUnderBuildDir/Cargo.toml")
+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ tasks.register<Copy>("copyRuntimeCrates") {
    into(runtimeOutputDir)
}

task("fixRuntimeCrateVersions") {
tasks.register("fixRuntimeCrateVersions") {
    dependsOn("copyRuntimeCrates")
    doLast {
        CrateSet.ENTIRE_SMITHY_RUNTIME.forEach { moduleName ->