Skip to content
Unverified Commit dfd53fb5 authored by ysaito1001's avatar ysaito1001 Committed by GitHub
Browse files

Make Rpc V2 CBOR `awsQuery` compatible (#4186)

## Description
This PR makes Rpc V2 CBOR a compatible protocol for `awsQuery` using
`awsQueryCompatible` trait, as described in the `Important` section in
[this
page](https://smithy.io/2.0/aws/protocols/aws-query-protocol.html#aws-protocols-awsquerycompatible-trait).

Previously, the implementation for `awsQueryCompatible` was tightly
coupled to `awsJson1_0`. This PR makes the implementation a bit more
abstract so that the implementation can support more target protocols
generically.

## Testing
- CI
- Made `AwsQueryCompatibleTest` parameterized tests to support RpcV2Cbor
and verified against modified cloudwatch service model (with
`awsQueryCompatible` trait applied). ~Tests for RpcV2Cbor is commented
out till https://github.com/smithy-lang/smithy-rs/pull/4185 is merged~.

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] For changes to the smithy-rs codegen or runtime crates, I have
created a changelog entry Markdown file in the `.changelog` directory,
specifying "client," "server," or both in the `applies_to` key.
- [x] For changes to the AWS SDK, generated SDK code, or SDK runtime
crates, I have created a changelog entry Markdown file in the
`.changelog` directory, specifying "aws-sdk-rust" in the `applies_to`
key.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent 8b32dee5
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment