Unverified Commit c5c87be5 authored by Julian Antonielli's avatar Julian Antonielli Committed by GitHub
Browse files

Add links to relevant issues/PRs for failing protocol tests (#1895) 



* Add links to relevant issues/PRs for failing tests

* Update codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/protocol/ServerProtocolTestGenerator.kt

Co-authored-by: default avatardavid-perez <d@vidp.dev>

* Format comment better

* Remove `RestJsonStreamingTraitsRequireLengthWithBlob` from failing tests

This test actually passes fine, but is not relevant for the server.

* Add comment about `RestJsonHttpResponseCodeDefaultsToModeledCode`

Co-authored-by: default avatardavid-perez <d@vidp.dev>
parent 87e1ed0c

codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/protocol/ServerProtocolTestGenerator.kt

+25 −10
Original line number Diff line number Diff line
@@ -872,31 +872,46 @@ class ServerProtocolTestGenerator( 
        private val AwsQuery = "aws.protocoltests.query#AwsQuery"

        private val Ec2Query = "aws.protocoltests.ec2#AwsEc2"

        private val ExpectFail = setOf<FailingTest>(

            // Headers.

            // Pending resolution from the Smithy team, see https://github.com/awslabs/smithy/issues/1068.

            FailingTest(RestJson, "RestJsonHttpWithHeadersButNoPayload", TestType.Request),



            FailingTest(RestJson, "RestJsonEndpointTrait", TestType.Request),

            FailingTest(RestJson, "RestJsonEndpointTraitWithHostLabel", TestType.Request),

            FailingTest(RestJson, "RestJsonStreamingTraitsRequireLengthWithBlob", TestType.Response),

            FailingTest(RestJson, "RestJsonHttpWithEmptyBlobPayload", TestType.Request),

            FailingTest(RestJson, "RestJsonHttpWithEmptyStructurePayload", TestType.Request),



            // See https://github.com/awslabs/smithy/issues/1098 for context.

            FailingTest(RestJson, "RestJsonHttpResponseCodeDefaultsToModeledCode", TestType.Response),



            // Endpoint trait is not implemented yet, see https://github.com/awslabs/smithy-rs/issues/950.

            FailingTest(RestJson, "RestJsonEndpointTrait", TestType.Request),

            FailingTest(RestJson, "RestJsonEndpointTraitWithHostLabel", TestType.Request),



            // Work in progress PR, see https://github.com/awslabs/smithy-rs/pull/1294.

            FailingTest(RestJson, "RestJsonBodyMalformedBlobInvalidBase64_case1", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonBodyMalformedBlobInvalidBase64_case2", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonWithBodyExpectsApplicationJsonContentType", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonBodyMalformedListNullItem", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonBodyMalformedMapNullValue", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonMalformedSetDuplicateItems", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonMalformedSetNullItem", TestType.MalformedRequest),

            FailingTest(

                RestJson,

                "RestJsonHeaderMalformedStringInvalidBase64MediaType_case1",

                TestType.MalformedRequest,

            ),

            FailingTest(RestJson, "RestJsonMalformedUnionNoFieldsSet", TestType.MalformedRequest),



            FailingTest(RestJson, "RestJsonWithBodyExpectsApplicationJsonContentType", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonBodyMalformedListNullItem", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonBodyMalformedMapNullValue", TestType.MalformedRequest),



            // Deprioritized, sets don't exist in Smithy 2.0.

            // They have the exact same semantics as list shapes with `@uniqueItems`,

            // so we could implement them as such once we've added support for constraint traits.

            //

            // See https://github.com/awslabs/smithy/issues/1266#issuecomment-1169543051.

            // See https://awslabs.github.io/smithy/2.0/guides/migrating-idl-1-to-2.html#convert-set-shapes-to-list-shapes.

            FailingTest(RestJson, "RestJsonMalformedSetDuplicateItems", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonMalformedSetNullItem", TestType.MalformedRequest),

            FailingTest(RestJson, "RestJsonMalformedSetDuplicateBlobs", TestType.MalformedRequest),



            FailingTest(RestJson, "RestJsonMalformedUnionNoFieldsSet", TestType.MalformedRequest),



            // Tests involving constraint traits, which are not yet implemented.

            // See https://github.com/awslabs/smithy-rs/pull/1342.

            FailingTest(RestJsonValidation, "RestJsonMalformedEnumList_case0", TestType.MalformedRequest),

            FailingTest(RestJsonValidation, "RestJsonMalformedEnumList_case1", TestType.MalformedRequest),

            FailingTest(RestJsonValidation, "RestJsonMalformedEnumMapKey_case0", TestType.MalformedRequest),