Unverified Commit b9f8090c authored by ysaito1001's avatar ysaito1001 Committed by GitHub
Browse files

Ensure cache miss logging works in concurrent setting (#2391) 



This commit ensures that logging for cache miss should be displayed
properly when multiple threads execute `get_or_load` concurrently.
Specifically, the log should be displayed only once for the first thread
that succeeds in populating a cache value.

Co-authored-by: default avatarYuki Saito <awsaito@amazon.com>
parent 52b07c2b

aws/rust-runtime/aws-credential-types/src/cache/lazy_caching.rs

+10 −4
Original line number Diff line number Diff line
@@ -106,6 +106,15 @@ impl ProvideCachedCredentials for LazyCredentialsCache { 
                                .buffer_time

                                .mul_f64((self.buffer_time_jitter_fraction)());



                            // Logging for cache miss should be emitted here as opposed to after the call to

                            // `cache.get_or_load` above. In the case of multiple threads concurrently executing

                            // `cache.get_or_load`, logging inside `cache.get_or_load` ensures that it is emitted

                            // only once for the first thread that succeeds in populating a cache value.

                            info!(

                                "credentials cache miss occurred; added new AWS credentials (took {:?})",

                                start_time.elapsed()

                            );



                            Ok((credentials, expiry + jitter))

                        }

                        // Only instrument the the actual load future so that no span
@@ -113,10 +122,7 @@ impl ProvideCachedCredentials for LazyCredentialsCache { 
                        .instrument(span)

                    })

                    .await;

                info!(

                    "credentials cache miss occurred; retrieved new AWS credentials (took {:?})",

                    start_time.elapsed()

                );

                debug!("loaded credentials");

                result

            }

        })