Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
Smithy Rust
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Public Repositories
Smithy Rust
Commits
b2c5eaa3
Unverified
Commit
b2c5eaa3
authored
2 years ago
by
John DiSanti
Committed by
GitHub
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Update RFC-26 (#2453)
parent
358d13a0
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
design/src/rfcs/rfc0026_client_crate_organization.md
+29
-17
29 additions, 17 deletions
design/src/rfcs/rfc0026_client_crate_organization.md
with
29 additions
and
17 deletions
design/src/rfcs/rfc0026_client_crate_organization.md
+
29
−
17
View file @
b2c5eaa3
RFC: Client Crate Organization
==============================
> Status:
Accep
ted
> Status:
Implemen
ted
>
> Applies to: clients (and may impact servers due to shared codegen)
...
...
@@ -374,19 +374,31 @@ All combined, the following is the new publicly visible organization:
Changes Checklist
-----------------
-
[ ] Move
`crate::AppName`
,
`crate::Endpoint`
,
`crate::Credentials`
, and
`crate::Region`
into
`crate::config`
-
[ ] Move
`crate::PKG_VERSION`
into a new
`crate::meta`
module
-
[ ] Move
`crate::operation::customize`
into
`crate::client`
-
[ ] Organize code generated types by operation
-
[ ] Reorganize builders that aren't per-operation
-
[ ] Only re-export
`aws_smithy_client::client::Builder`
for non-SDK clients (remove from SDK clients)
-
[ ] Rename
`crate::types`
to
`crate::primitives`
-
[ ] Rename
`crate::model`
to
`crate::types`
-
[ ] Move
`crate::error`
into
`crate::types`
-
[ ] Move
`crate::ErrorExt`
into
`crate::error`
-
[ ] Re-export
`aws_smithy_types::error::display::DisplayErrorContext`
and
`aws_smithy_http::result::SdkError`
in
`crate::error`
-
[ ] Move
`crate::paginator`
into
`crate::operation`
-
[ ] Flatten
`crate::presigning`
-
[ ] Remove/hide operation
`ParseResponse`
implementations in
`crate::operation`
-
[ ] Hide or remove
`crate::lens`
and
`crate::http_body_checksum`
-
[ ] Update "Crate Organization" top-level section in generated crate docs
-
[x] Move
`crate::AppName`
into
`crate::config`
-
[x] Move
`crate::PKG_VERSION`
into a new
`crate::meta`
module
-
[x] Move
`crate::Endpoint`
into
`crate::config`
-
[x] Move
`crate::Credentials`
into
`crate::config`
-
[x] Move
`crate::Region`
into
`crate::config`
-
[x] Move
`crate::operation::customize`
into
`crate::client`
-
[x] Finish refactor to decouple client/server modules
-
[x] Organize code generated types by operation
-
[x] Reorganize builders
-
[x] Rename
`crate::types`
to
`crate::primitives`
-
[x] Rename
`crate::model`
to
`crate::types`
-
[x] Move
`crate::error`
into
`crate::types`
-
[x] Only re-export
`aws_smithy_client::client::Builder`
for non-SDK clients (remove from SDK clients)
-
[x] Move
`crate::ErrorExt`
into
`crate::error`
-
[x] Re-export
`aws_smithy_types::error::display::DisplayErrorContext`
and
`aws_smithy_http::result::SdkError`
in
`crate::error`
-
[x] Move
`crate::paginator`
into
`crate::operation`
-
[x] Flatten
`crate::presigning`
-
[x] Hide or remove
`crate::lens`
and
`crate::http_body_checksum`
-
[x] Move fluent builders into
`crate::operation::x::builders`
-
[x] Remove/hide operation
`ParseResponse`
implementations in
`crate::operation`
-
[x] Update "Crate Organization" top-level section in generated crate docs
-
[x] Update all module docs
-
[x] Break up modules/files so that they're not 30k lines of code
-
[x] models/types; each struct/enum should probably get its own file with pub-use
-
[x] models/types::builders: now this needs to get split up
-
[x]
`client.rs`
-
[x] Fix examples
-
[x] Write changelog
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment