Unverified Commit a88fff1a authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

breaking: Remove make test-util and optional feature (#608) 



* breaking: Remove make test-util and optional feature

for historical reasons, `test-util` was enabled by default in aws-hyper. This change:
* removes the pub use for test util in aws-hyper
* updates usages to use it in smithy-client
* updates the crate dependencies to correctly pull in the new feature but only for development

NOTE: please wait for a full cargoTest all crates prior to merging this change.

* Update CHANGELOG.md

* fix non-optional smithy client dependencies

* Update CHANGELOG.md

Co-authored-by: default avatarJohn DiSanti <jdisanti@amazon.com>

Co-authored-by: default avatarJohn DiSanti <jdisanti@amazon.com>
parent 0e9a986b

CHANGELOG.md

+6 −0
Original line number Diff line number Diff line 
## vNext (Month Day Year)



**Breaking changes**

* `test-util` has been made an optional dependency and has moved from

  aws-hyper to smithy-http. If you were relying on `aws_hyper::TestConnection`, add `smithy-client` as a dependency

  and enable the optional `test-util` feature. This prunes some unnecessary dependencies on `roxmltree` and `serde_json`

  for most users. (#608)



**New This Week**

- :bug: Bugfix: Fix parsing bug where whitespace was stripped when parsing XML (#590)

- Establish common abstraction for environment variables (#594)

aws/rust-runtime/aws-hyper/Cargo.toml

+2 −5
Original line number Diff line number Diff line
@@ -8,8 +8,7 @@ license = "Apache-2.0" 
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html



[features]

test-util = ["protocol-test-helpers"]

default = ["test-util"]

default = []

native-tls = ["hyper-tls", "smithy-client/native-tls"]

rustls = ["hyper-rustls", "smithy-client/rustls"]
@@ -35,13 +34,11 @@ tokio = { version = "1", features = ["time"] } 
pin-project = "1"

tracing = "0.1"



protocol-test-helpers = { path = "../../../rust-runtime/protocol-test-helpers", optional = true }



[dev-dependencies]

tokio = { version = "1", features = ["full", "test-util"] }

tower-test = "0.4.0"

aws-types = { path = "../aws-types" }

smithy-client = { path = "../../../rust-runtime/smithy-client", features = ["test-util"] }



[[test]]

name = "e2e_test"
 
required-features = ["test-util"]

aws/rust-runtime/aws-hyper/src/lib.rs

+0 −3
Original line number Diff line number Diff line
@@ -3,9 +3,6 @@ 
 * SPDX-License-Identifier: Apache-2.0.

 */



#[doc(inline)]

pub use smithy_client::test_connection;



pub use smithy_client::retry::Config as RetryConfig;



use aws_auth::middleware::CredentialsStage;

aws/rust-runtime/aws-hyper/tests/e2e_test.rs

+1 −1
Original line number Diff line number Diff line
@@ -8,7 +8,6 @@ use aws_endpoint::partition::endpoint::{Protocol, SignatureVersion}; 
use aws_endpoint::set_endpoint_resolver;

use aws_http::user_agent::AwsUserAgent;

use aws_http::AwsErrorRetryPolicy;

use aws_hyper::test_connection::TestConnection;

use aws_hyper::{Client, RetryConfig};

use aws_sig_auth::signer::OperationSigningConfig;

use aws_types::region::Region;
@@ -16,6 +15,7 @@ use aws_types::SigningService; 
use bytes::Bytes;

use http::header::{AUTHORIZATION, HOST, USER_AGENT};

use http::{Response, Uri};

use smithy_client::test_connection::TestConnection;

use smithy_http::body::SdkBody;

use smithy_http::operation;

use smithy_http::operation::Operation;

aws/rust-runtime/aws-types/Cargo.toml

+1 −1
Original line number Diff line number Diff line
@@ -18,4 +18,4 @@ serde_json = "1" 
arbitrary = "1"



[build-dependencies]

rustc_version = "0.3.3"
 
rustc_version = "0.4.0"