-
- Downloads
Stream implementation (wrapper) for PaginationStream (#3299)
## Motivation and Context https://github.com/awslabs/aws-sdk-rust/discussions/995 ## Description I tried to implement futures::Stream for a wrapper struct around `PaginationStream`. I am unsure if I did it in the best way. After fighting with the borrow checker for a while I decided to try `Arc<Mutex<_>>` - is this the way to go or does there exist a better way? Even then, does the code look correct? I used it in my project and my integration tests do pass but I am not 100% that these tests will catch any error in paginated ListObjectsV2. I would appreciate any feedback so far. ## Testing In progress while waiting for feedback on code ## Checklist - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by:Russell Cohen <rcoh@amazon.com> Co-authored-by:
Russell Cohen <russell.r.cohen@gmail.com>
Showing
- CHANGELOG.next.toml 28 additions, 0 deletionsCHANGELOG.next.toml
- rust-runtime/aws-smithy-async/src/future/pagination_stream.rs 7 additions, 0 deletions...-runtime/aws-smithy-async/src/future/pagination_stream.rs
- rust-runtime/aws-smithy-types-convert/Cargo.toml 3 additions, 0 deletionsrust-runtime/aws-smithy-types-convert/Cargo.toml
- rust-runtime/aws-smithy-types-convert/external-types.toml 2 additions, 0 deletionsrust-runtime/aws-smithy-types-convert/external-types.toml
- rust-runtime/aws-smithy-types-convert/src/lib.rs 3 additions, 0 deletionsrust-runtime/aws-smithy-types-convert/src/lib.rs
- rust-runtime/aws-smithy-types-convert/src/stream.rs 62 additions, 0 deletionsrust-runtime/aws-smithy-types-convert/src/stream.rs
Loading
Please register or sign in to comment