Skip to content
Unverified Commit 66692b35 authored by Fahad Zubair's avatar Fahad Zubair Committed by GitHub
Browse files

Merge documentation of same inline modules (#4008)



When two inline modules with the same name are generated from different
parts of the codebase, their documentation should be merged. However,
other metadata must match exactly, as it is an error for one part of the
codebase to define an inline module with pub visibility while another
defines it with pub(crate) visibility.

This PR enables documentation merging while maintaining strict
validation of other metadata fields.

Currently, the following sample model fails to generate code because
both `SomeList` and `member` are generated in the same inline module but
with different doc comments:

```smithy
@documentation("Outer constraint has some documentation")
@length(max: 3)
list SomeList {
    @length(max: 8000)
    member: String
}
```

Co-authored-by: default avatarFahad Zubair <fahadzub@amazon.com>
parent 77e80622
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment