Skip to content
Unverified Commit 44ece8e0 authored by Harry Barber's avatar Harry Barber Committed by GitHub
Browse files

Prevent build stalling with overlapping projections (#2602)

## Motivation and Context

Smithy CLI runs projections concurrently, for some currently unknown
reason this causes the build to stall.

## Description

- Switch `defaultRustMetadata` in `BaseSymbolMetadataProvider` from a
`val` to a `fun`.
- Remove unused `RustType::TestModule` companion object.

## Notes

A deadlock occurs when the client/server plugins both attempt to grab
file locks. While this fixes this deadlock it is unknown whether there
still exist conditions where it can happen.

## Testing

1. Checkout
https://github.com/crisidev/smithy-rs-pokemon-service/commit/d276bb95bbd7bf5c5f029953b8f16cecfa8af24f,
run `./gradlew assemble`, and observe the build halting.
2. Run the following commands to switch to this branch:
```bash
git submodule update --init --recursive --remote
cd smithy-rs
git checkout harryb/remove-build-deadlock
cd ..
./gradlew assemble
```
3. Observe the build succeeding.
parent 1a65a44e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment