Skip to content
Unverified Commit 3f80a071 authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Fix several waiter path matcher issues (#3593)

While implementing waiters in another branch, I discovered and fixed a
number of issues with the path matcher codegen logic. These issues were:

- Generated code for nested flatten projections failed to compile due to
the first projection producing a `Vec<Vec<&T>>` instead of `Vec<&T>`.
- Path matchers that don't use input were taking input as an argument
anyway, which results in an unnecessary clone of the input when used by
the generated waiter logic.
- The comparisons generated by `RustWaiterMatcherGenerator` would fail
to compile whenever comparing a string against an enum.

This PR fixes all these issues.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent 08cb8a2e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment