Unverified Commit 06e265df authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

Update SDK external types (#3080) 

## Motivation and Context
- https://github.com/awslabs/smithy-rs/issues/3019

## Description
Prune / split out allow external types

## Testing
- CI

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent 5a8b07c6

aws/sdk/sdk-external-types.toml

+22 −13
Original line number Diff line number Diff line 
# These are the allowed external types in the `aws-sdk-*` generated crates, checked by CI.

allowed_external_types = [

    "aws_credential_types::*",

    "aws_http::*",

    "aws_runtime::*",

    "aws_smithy_async::*",

    "aws_smithy_http::*",

    "aws_smithy_runtime::*",

    "aws_smithy_runtime_api::*",

    "aws_smithy_types::*",

    "aws_credential_types::*",

    "aws_types::*",



    "http::header::map::HeaderMap",

    "http::header::value::HeaderValue",

    "aws_smithy_runtime_api::*",

    "aws_smithy_async::rt::sleep::*",

    "aws_smithy_async::time::*",

    "aws_smithy_async::future::pagination_stream::PaginationStream",

    # only allowed in from impl for presigned request

    "http::request::Request",

    "http::error::Error",

    "http::uri::Uri",

    "http::method::Method",



    # TODO(https://github.com/awslabs/smithy-rs/issues/1193): Once tooling permits it, only allow the following types in the `event-stream` feature

    "aws_smithy_eventstream::*",



    # Consider moving making this crate 1.0

    "aws_smithy_runtime::client::identity::cache::IdentityCache",



    ### All below this line need to be fixed:

    # The following are not OK

    "aws_http::request_id::RequestId", # move to aws-types

    # `set_invocation_id_generator` — consider make pub(crate) or moving trait to AwsTypes

    "aws_runtime::invocation_id::SharedInvocationIdGenerator",

    "aws_runtime::invocation_id::InvocationIdGenerator",



    # Pending fix in open PRs:

    "aws_smithy_http::result::*",



    # Pending future fix

    "aws_smithy_http::event_stream::*",

]